Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(algebraic_geometry/morphisms/basic): Morphism properties on the diagonal morphism. #16111

Closed
wants to merge 7 commits into from
Closed

[Merged by Bors] - feat(algebraic_geometry/morphisms/basic): Morphism properties on the diagonal morphism. #16111

wants to merge 7 commits into from

Conversation

erdOne
Copy link
Member

@erdOne erdOne commented Aug 17, 2022

Open in Gitpod

@erdOne erdOne added the t-algebraic-geometry Algebraic geometry label Aug 17, 2022
@erdOne erdOne added the awaiting-review The author would like community review of the PR label Aug 18, 2022
jcommelin
jcommelin reviewed Aug 24, 2022
View reviewed changes
src/category_theory/morphism_property.lean Outdated Show resolved Hide resolved
src/category_theory/morphism_property.lean Outdated Show resolved Hide resolved
src/category_theory/morphism_property.lean Outdated Show resolved Hide resolved
src/category_theory/morphism_property.lean Outdated Show resolved Hide resolved
src/algebraic_geometry/morphisms/basic.lean Outdated Show resolved Hide resolved
@jcommelin jcommelin added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Aug 24, 2022
@erdOne erdOne added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Oct 4, 2022
jcommelin
jcommelin approved these changes Oct 5, 2022
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-bot-assistant leanprover-community-bot-assistant added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Oct 5, 2022
bors bot pushed a commit that referenced this pull request Oct 5, 2022
@erdOne
feat(algebraic_geometry/morphisms/basic): Morphism properties on the …
7316286 
…diagonal morphism. (#16111)
@bors
Copy link

bors bot commented Oct 5, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(algebraic_geometry/morphisms/basic): Morphism properties on the diagonal morphism. [Merged by Bors] - feat(algebraic_geometry/morphisms/basic): Morphism properties on the diagonal morphism. Oct 5, 2022
@bors bors bot closed this Oct 5, 2022
@bors bors bot deleted the diagonal_morphism_property branch October 5, 2022 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) t-algebraic-geometry Algebraic geometry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@erdOne @jcommelin @leanprover-community-bot-assistant