Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - split(analysis/convex/segment): Split off analysis/convex.basic #16112

Closed
wants to merge 1 commit into from

Conversation

YaelDillies
Copy link
Collaborator

Move segment and open_segment to a new file analysis.convex.segment.


This is to redefine convex in terms of star_convex.

Zulip

Open in Gitpod

@YaelDillies YaelDillies added the awaiting-review The author would like community review of the PR label Aug 17, 2022
@YaelDillies YaelDillies requested a review from urkud August 17, 2022 23:03
@YaelDillies YaelDillies added the t-analysis Analysis (normed *, calculus) label Aug 19, 2022
@urkud
Copy link
Member

urkud commented Aug 20, 2022

Are there any API changes?

@urkud
Copy link
Member

urkud commented Aug 20, 2022

If not, then feel free to merge. Thanks!
bors d+

@bors
Copy link

bors bot commented Aug 20, 2022

✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Aug 20, 2022
@YaelDillies
Copy link
Collaborator Author

None!

bors merge

bors bot pushed a commit that referenced this pull request Aug 20, 2022
…6112)

Move `segment` and `open_segment` to a new file `analysis.convex.segment`.
@bors
Copy link

bors bot commented Aug 20, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title split(analysis/convex/segment): Split off analysis/convex.basic [Merged by Bors] - split(analysis/convex/segment): Split off analysis/convex.basic Aug 20, 2022
@bors bors bot closed this Aug 20, 2022
@bors bors bot deleted the split_segment branch August 20, 2022 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated The PR author may merge after reviewing final suggestions. t-analysis Analysis (normed *, calculus)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants