[Merged by Bors] - split(analysis/normed/group/seminorm): Split off analysis.seminorm
#16152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YaelDillies
added
the
awaiting-review
3 tasks
|
Are there any API changes? For the first move, you don't mention the name of the new file in the commit message. |
|
The only API change is
I can single it out to another PR if you ask. I was just impatient 😝 |
1 task
leanprover-community-bot-assistant
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Aug 24, 2022
…16152) Move `group_seminorm` and `add_group_seminorm` to a new file `analysis.normed.group.seminorm`. Move `norm_add_group_seminorm` to `analysis.normed.group.basic`. Remove the `nonneg` field from `add_group_seminorm` and `group_seminorm` because it is redundant.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
analysis.seminormanalysis.seminorm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move
group_seminormandadd_group_seminormto a new fileanalysis.normed.group.seminorm. Movenorm_add_group_seminormtoanalysis.normed.group.basic. Remove thenonnegfield fromadd_group_seminormandgroup_seminormbecause it is redundant.The goal is to rebase normed groups on seminorms. For this, we need to separate
add_group_seminorm/group_seminormfromseminormbecauseseminormdepends onsemi_normed_ring, which will eventually depend onadd_group_seminorm.The folder organisation I am now aiming for is
analysis.normedgroupseminorm: Group norms and seminorms as homomorphisms (the file here, but the norms are missing).basic: Group norms and seminorms as classes (as it is today).ringorfieldseminorm: Ring norms and seminorms as homomorphisms (as is being added in [Merged by Bors] - feat(analysis/normed/ring/seminorm): add ring_seminorm, ring_norm #14115).basic: Ring norms and seminorms as classes (as it is today.moduleorspaceseminorm: Module norms and seminorms as homomorphisms (as it is inanalysis.seminormtoday, but the norms are missing).basic: Ring norms and seminorms as classes (as it is inanalysis.normed_space.basictoday).Every time, the
.basicfile would import the.seminormfile, rather than the other way around.Zulip