Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(data/set/intervals/unordered_interval): Intervals are injective in both endpoints #16168

Closed
wants to merge 6 commits into from
Closed

[Merged by Bors] - feat(data/set/intervals/unordered_interval): Intervals are injective in both endpoints #16168

wants to merge 6 commits into from

Conversation

YaelDillies
Copy link
Collaborator

set.interval a and set.interval_oc a are injective.

Requested by @b-mehta

Open in Gitpod

@YaelDillies YaelDillies added awaiting-review The author would like community review of the PR t-order Order hierarchy labels Aug 20, 2022
b-mehta
b-mehta reviewed Aug 20, 2022
View reviewed changes
src/data/set/intervals/unordered_interval.lean Outdated Show resolved Hide resolved
src/data/set/intervals/unordered_interval.lean Outdated Show resolved Hide resolved
src/data/set/intervals/unordered_interval.lean Outdated Show resolved Hide resolved
@b-mehta
Copy link
Collaborator

b-mehta commented Oct 7, 2022

Looks good to me, but I suggested these lemmas and wrote some old versions of them, so someone else should check too.

bors d=@Vierkantor

@bors
Copy link

bors bot commented Oct 7, 2022

✌️ Vierkantor can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Oct 7, 2022
Vierkantor
Vierkantor reviewed Oct 8, 2022
View reviewed changes
Copy link
Collaborator

@Vierkantor Vierkantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@leanprover-community-bot-assistant leanprover-community-bot-assistant added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Oct 8, 2022
bors bot pushed a commit that referenced this pull request Oct 8, 2022
@YaelDillies
feat(data/set/intervals/unordered_interval): Intervals are injective …
37eef1c 
…in both endpoints (#16168)

`set.interval a` and `set.interval_oc a` are injective.
@bors
Copy link

bors bot commented Oct 8, 2022

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Oct 8, 2022
@YaelDillies
feat(data/set/intervals/unordered_interval): Intervals are injective …
5b0a648 
…in both endpoints (#16168)

`set.interval a` and `set.interval_oc a` are injective.
@bors
Copy link

bors bot commented Oct 8, 2022

Build failed (retrying...):

@bors
Copy link

bors bot commented Oct 8, 2022

Canceled.

@YaelDillies
Copy link
Collaborator Author

bors merge

@bors
Copy link

bors bot commented Oct 9, 2022

🔒 Permission denied

Existing reviewers: click here to make YaelDillies a reviewer

@YaelDillies
Copy link
Collaborator Author

The first merge failed because mem_union_eq was replaced by mem_union. I fixed this so

maintainer merge

@github-actions
Copy link

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

jcommelin
jcommelin approved these changes Oct 11, 2022
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

bors bot pushed a commit that referenced this pull request Oct 11, 2022
@YaelDillies
feat(data/set/intervals/unordered_interval): Intervals are injective …
e1a9f05 
…in both endpoints (#16168)

`set.interval a` and `set.interval_oc a` are injective.
@bors
Copy link

bors bot commented Oct 11, 2022

This PR was included in a batch that was canceled, it will be automatically retried

bors bot pushed a commit that referenced this pull request Oct 11, 2022
@YaelDillies
feat(data/set/intervals/unordered_interval): Intervals are injective …
6cb6334 
…in both endpoints (#16168)

`set.interval a` and `set.interval_oc a` are injective.
@bors
Copy link

bors bot commented Oct 11, 2022

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Oct 11, 2022
@YaelDillies
feat(data/set/intervals/unordered_interval): Intervals are injective …
0a0be05 
…in both endpoints (#16168)

`set.interval a` and `set.interval_oc a` are injective.
@bors
Copy link

bors bot commented Oct 12, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(data/set/intervals/unordered_interval): Intervals are injective in both endpoints [Merged by Bors] - feat(data/set/intervals/unordered_interval): Intervals are injective in both endpoints Oct 12, 2022
@bors bors bot closed this Oct 12, 2022
@bors bors bot deleted the interval_injective branch October 12, 2022 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vierkantor Vierkantor Vierkantor left review comments

@alreadydone alreadydone alreadydone left review comments

@jcommelin jcommelin jcommelin approved these changes

@b-mehta b-mehta Awaiting requested review from b-mehta

Assignees
No one assigned
Labels
delegated The PR author may merge after reviewing final suggestions. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) t-order Order hierarchy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@YaelDillies @b-mehta @Vierkantor @alreadydone @jcommelin @leanprover-community-bot-assistant