Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore(algebra/order/monoid): move lemmas #16176

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - chore(algebra/order/monoid): move lemmas #16176

wants to merge 2 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Aug 20, 2022

  • move with_top.coe_nat to algebra.order.monoid, prove by rfl;
  • move with_top.nat_ne_top and with_top.top_ne_nat to algebra.order.monoid;
  • add with_bot versions.

Open in Gitpod

@urkud urkud added awaiting-review The author would like community review of the PR t-algebra Algebra (groups, rings, fields etc) t-order Order hierarchy easy < 20s of review time. See the lifecycle page for guidelines. labels Aug 20, 2022
@ocfnash
Copy link
Collaborator

ocfnash commented Aug 22, 2022

Thanks!

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Aug 22, 2022
bors bot pushed a commit that referenced this pull request Aug 22, 2022
@urkud
chore(algebra/order/monoid): move lemmas (#16176)
cf7b16a 
* move `with_top.coe_nat` to `algebra.order.monoid`, prove by `rfl`;
* move `with_top.nat_ne_top` and `with_top.top_ne_nat` to `algebra.order.monoid`;
* add `with_bot` versions.
@bors
Copy link

bors bot commented Aug 22, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(algebra/order/monoid): move lemmas [Merged by Bors] - chore(algebra/order/monoid): move lemmas Aug 22, 2022
@bors bors bot closed this Aug 22, 2022
@bors bors bot deleted the YK-with-top-coe-nat branch August 22, 2022 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) t-algebra Algebra (groups, rings, fields etc) t-order Order hierarchy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@urkud @ocfnash