Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore(algebra/algebra/spectrum): generalize some spectrum results from alg_hom to alg_hom_class #16177

Closed
wants to merge 5 commits into from
Closed

[Merged by Bors] - chore(algebra/algebra/spectrum): generalize some spectrum results from alg_hom to alg_hom_class #16177

wants to merge 5 commits into from

Conversation

j-loreaux
Copy link
Collaborator

@j-loreaux j-loreaux commented Aug 20, 2022 •
edited

@j-loreaux j-loreaux added awaiting-CI The author would like to see what CI has to say before doing more work. awaiting-review The author would like community review of the PR easy < 20s of review time. See the lifecycle page for guidelines. t-algebra Algebra (groups, rings, fields etc) labels Aug 20, 2022
@j-loreaux j-loreaux removed the easy < 20s of review time. See the lifecycle page for guidelines. label Aug 21, 2022
@urkud urkud added the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Aug 21, 2022
@urkud
Copy link
Member

urkud commented Aug 21, 2022

I don't understand why bors didn't add blocked-by-other-PR

@j-loreaux
Copy link
Collaborator Author

maybe because I added the dependency after the initial PR?

@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Aug 21, 2022
@mathlib-dependent-issues-bot mathlib-dependent-issues-bot removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Aug 23, 2022
@mathlib-dependent-issues-bot
Copy link
Collaborator

This PR/issue depends on:

@j-loreaux j-loreaux added awaiting-author A reviewer has asked the author a question or requested changes merge-conflict Please `git merge origin/master` then a bot will remove this label. and removed awaiting-review The author would like community review of the PR labels Aug 23, 2022
@j-loreaux j-loreaux added awaiting-CI The author would like to see what CI has to say before doing more work. awaiting-review The author would like community review of the PR and removed merge-conflict Please `git merge origin/master` then a bot will remove this label. awaiting-author A reviewer has asked the author a question or requested changes labels Aug 23, 2022
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Aug 23, 2022
@j-loreaux j-loreaux mentioned this pull request Aug 23, 2022
Closed
2 tasks
@dupuisf
Copy link
Collaborator

dupuisf commented Aug 23, 2022

Looks good!

bors r+

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Aug 23, 2022
bors bot pushed a commit that referenced this pull request Aug 23, 2022
@j-loreaux
chore(algebra/algebra/spectrum): generalize some spectrum results fro…
6f1ad82 
…m `alg_hom` to `alg_hom_class` (#16177)

- [x] depends on: #16178
@bors
Copy link

bors bot commented Aug 23, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(algebra/algebra/spectrum): generalize some spectrum results from alg_hom to alg_hom_class [Merged by Bors] - chore(algebra/algebra/spectrum): generalize some spectrum results from alg_hom to alg_hom_class Aug 23, 2022
@bors bors bot closed this Aug 23, 2022
@bors bors bot deleted the j-loreaux/spectrum-alg-hom-class branch August 23, 2022 18:44
bors bot pushed a commit that referenced this pull request Aug 26, 2022
@j-loreaux
feat(analysis/normed_space/star/spectrum): star algebra morphisms ove…
5ef6426 
…r ℂ are norm contractive (#16219)

- [x] depends on: #16177
- [x] depends on: #16212
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) t-algebra Algebra (groups, rings, fields etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@j-loreaux @urkud @mathlib-dependent-issues-bot @dupuisf