Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(category_theory/limits/shapes/products): if each f b ⟶ g b is mono, then ∏ f ⟶ ∏ g is mono #16180

Closed
wants to merge 6 commits into from
Closed

[Merged by Bors] - feat(category_theory/limits/shapes/products): if each f b ⟶ g b is mono, then ∏ f ⟶ ∏ g is mono #16180

wants to merge 6 commits into from

Conversation

jjaassoonn
Copy link
Collaborator

and its dual version: if each f b ⟶ g b is epi, then ∐ f ⟶ ∐ g is epi

Open in Gitpod

@jjaassoonn jjaassoonn mentioned this pull request Aug 21, 2022
Draft
11 tasks
@jjaassoonn jjaassoonn added awaiting-review The author would like community review of the PR awaiting-CI The author would like to see what CI has to say before doing more work. labels Aug 21, 2022
@TwoFX TwoFX added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Aug 21, 2022
@jjaassoonn jjaassoonn added awaiting-review The author would like community review of the PR awaiting-CI The author would like to see what CI has to say before doing more work. and removed awaiting-author A reviewer has asked the author a question or requested changes awaiting-CI The author would like to see what CI has to say before doing more work. labels Aug 21, 2022
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Aug 21, 2022
@jjaassoonn jjaassoonn added blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. and removed awaiting-review The author would like community review of the PR labels Aug 21, 2022
@mathlib-dependent-issues-bot mathlib-dependent-issues-bot removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Aug 21, 2022
@jjaassoonn jjaassoonn added awaiting-review The author would like community review of the PR awaiting-CI The author would like to see what CI has to say before doing more work. labels Sep 2, 2022
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Sep 2, 2022
TwoFX
TwoFX approved these changes Sep 6, 2022
View reviewed changes
Copy link
Member

@TwoFX TwoFX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
bors d+

src/category_theory/limits/has_limits.lean Outdated Show resolved Hide resolved
src/category_theory/limits/has_limits.lean Outdated Show resolved Hide resolved
@bors
Copy link

bors bot commented Sep 6, 2022

✌️ jjaassoonn can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-bot-assistant leanprover-community-bot-assistant added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Sep 6, 2022
@jjaassoonn @TwoFX
Apply suggestions from code review
9becac8 
Co-authored-by: Markus Himmel <markus@himmel-villmar.de>
@jjaassoonn jjaassoonn added the awaiting-CI The author would like to see what CI has to say before doing more work. label Sep 6, 2022
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Sep 6, 2022
@jjaassoonn
Copy link
Collaborator Author

bors r+

bors bot pushed a commit that referenced this pull request Sep 6, 2022
@jjaassoonn
feat(category_theory/limits/shapes/products): if each f b ⟶ g b is …
e11bafa 
…mono, then `∏ f ⟶ ∏ g` is mono (#16180)

and its dual version: if each `f b ⟶ g b` is epi, then `∐ f ⟶ ∐ g` is epi
@bors
Copy link

bors bot commented Sep 6, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(category_theory/limits/shapes/products): if each f b ⟶ g b is mono, then ∏ f ⟶ ∏ g is mono [Merged by Bors] - feat(category_theory/limits/shapes/products): if each f b ⟶ g b is mono, then ∏ f ⟶ ∏ g is mono Sep 6, 2022
@bors bors bot closed this Sep 6, 2022
@bors bors bot deleted the jjaassoonn/product_map_mono branch September 6, 2022 09:59
b-mehta pushed a commit that referenced this pull request Sep 21, 2022
@jjaassoonn @b-mehta
feat(category_theory/limits/shapes/products): if each f b ⟶ g b is …
64d135d 
…mono, then `∏ f ⟶ ∏ g` is mono (#16180)

and its dual version: if each `f b ⟶ g b` is epi, then `∐ f ⟶ ∐ g` is epi
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TwoFX TwoFX TwoFX approved these changes

Assignees
No one assigned
Labels
delegated The PR author may merge after reviewing final suggestions.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jjaassoonn @TwoFX @leanprover-community-bot-assistant @mathlib-dependent-issues-bot