Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore(algebra/order/absolute_value): superficial tidying #16190

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - chore(algebra/order/absolute_value): superficial tidying #16190

wants to merge 3 commits into from

Conversation

ericrbg
Copy link
Collaborator

@ericrbg ericrbg commented Aug 21, 2022 •
edited by jcommelin

This weakens the requirements of many lemmas in this file, preparing for further changes. is_absolute_value is unbundled, which is an approach that is currently not favoured in mathlib.

Open in Gitpod

@ericrbg ericrbg added awaiting-CI The author would like to see what CI has to say before doing more work. awaiting-review The author would like community review of the PR t-algebra Algebra (groups, rings, fields etc) labels Aug 21, 2022
@ericrbg ericrbg mentioned this pull request Aug 21, 2022
Closed
1 task
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Aug 22, 2022
ericrbg and others added 2 commits August 24, 2022 06:09
@ericrbg @jcommelin
Update src/algebra/order/absolute_value.lean
74cef42 
Co-authored-by: Johan Commelin <johan@commelin.net>
@ericrbg
Revert "Update src/algebra/order/absolute_value.lean"
f402f0c 
This reverts commit 74cef42.
@ericrbg
Copy link
Collaborator Author

ericrbg commented Aug 24, 2022

map_one' is for a typeclass that depends on the function, so I don't think simp will like it very much. After this merges I'll try switch fully to the bundled approach, and then this can be made a simp lemma/(hopefully) the monoid_with_zero_hom instance(s - I can't see how to avoid this without a cancel_semiring class) will take care of it.

jcommelin
jcommelin reviewed Aug 31, 2022
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-bot-assistant leanprover-community-bot-assistant added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Aug 31, 2022
bors bot pushed a commit that referenced this pull request Aug 31, 2022
@ericrbg
chore(algebra/order/absolute_value): superficial tidying (#16190)
76be8c7 
This weakens the requirements of many lemmas in this file, preparing for further changes. `is_absolute_value` is unbundled, which is an approach that is currently not favoured in mathlib.



Co-authored-by: Eric Rodriguez <37984851+ericrbg@users.noreply.github.com>
@bors
Copy link

bors bot commented Aug 31, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(algebra/order/absolute_value): superficial tidying [Merged by Bors] - chore(algebra/order/absolute_value): superficial tidying Aug 31, 2022
@bors bors bot closed this Aug 31, 2022
@bors bors bot deleted the ericrbg/absolute_value1 branch August 31, 2022 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin left review comments

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) t-algebra Algebra (groups, rings, fields etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ericrbg @jcommelin @leanprover-community-bot-assistant