Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(analysis/special_functions/trigonometric/angle): continuity and signs #16204

Closed
wants to merge 2 commits into from

Conversation

jsm28
Copy link
Collaborator

@jsm28 jsm28 commented Aug 22, 2022

Add the lemmas that real.angle.sign is continuous away from 0 and π,
and thus that any function to angles that is continuous on a connected
set and does not take the value 0 or π on that set produces angles
with constant sign on that set (this is a general principle for use in
proving results about when two oriented angles in a geometrical
configuration must have the same sign).


Open in Gitpod

…signs

Add the lemmas that `real.angle.sign` is continuous away from 0 and π,
and thus that any function to angles that is continuous on a connected
set and does not take the value 0 or π on that set produces angles
with constant sign on that set (this is a general principle for use in
proving results about when two oriented angles in a geometrical
configuration must have the same sign).
@jsm28 jsm28 added awaiting-review The author would like community review of the PR t-analysis Analysis (normed *, calculus) labels Aug 22, 2022
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-bot-assistant leanprover-community-bot-assistant added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Aug 24, 2022
bors bot pushed a commit that referenced this pull request Aug 24, 2022
…signs (#16204)

Add the lemmas that `real.angle.sign` is continuous away from 0 and π,
and thus that any function to angles that is continuous on a connected
set and does not take the value 0 or π on that set produces angles
with constant sign on that set (this is a general principle for use in
proving results about when two oriented angles in a geometrical
configuration must have the same sign).
@bors
Copy link

bors bot commented Aug 24, 2022

This PR was included in a batch that was canceled, it will be automatically retried

bors bot pushed a commit that referenced this pull request Aug 24, 2022
…signs (#16204)

Add the lemmas that `real.angle.sign` is continuous away from 0 and π,
and thus that any function to angles that is continuous on a connected
set and does not take the value 0 or π on that set produces angles
with constant sign on that set (this is a general principle for use in
proving results about when two oriented angles in a geometrical
configuration must have the same sign).
@bors
Copy link

bors bot commented Aug 24, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(analysis/special_functions/trigonometric/angle): continuity and signs [Merged by Bors] - feat(analysis/special_functions/trigonometric/angle): continuity and signs Aug 24, 2022
@bors bors bot closed this Aug 24, 2022
@bors bors bot deleted the jsm28/angle_continuous_sign branch August 24, 2022 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) t-analysis Analysis (normed *, calculus)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants