Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(algebra/order/smul): ordered_smul instances for ℕ and ℤ #16247

Closed
wants to merge 4 commits into from
Closed

[Merged by Bors] - feat(algebra/order/smul): ordered_smul instances for ℕ and ℤ #16247

wants to merge 4 commits into from

Conversation

YaelDillies
Copy link
Collaborator

A linear ordered monoid/group has ordered scalar multiplication by ℕ/ℤ.

Thanks to Oliver for the original code!

Open in Gitpod

@YaelDillies YaelDillies added awaiting-review The author would like community review of the PR t-algebra Algebra (groups, rings, fields etc) t-order Order hierarchy labels Aug 25, 2022
@YaelDillies YaelDillies mentioned this pull request Aug 25, 2022
Closed
@jcommelin jcommelin added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Aug 29, 2022
@YaelDillies YaelDillies added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Aug 29, 2022
jcommelin
jcommelin approved these changes Aug 31, 2022
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-bot-assistant leanprover-community-bot-assistant added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Aug 31, 2022
bors bot pushed a commit that referenced this pull request Aug 31, 2022
@YaelDillies
feat(algebra/order/smul): ordered_smul instances for ℕ and ℤ (#…
eaa51e7 
…16247)

A linear ordered monoid/group has ordered scalar multiplication by `ℕ`/`ℤ`.
@bors
Copy link

bors bot commented Aug 31, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(algebra/order/smul): ordered_smul instances for ℕ and ℤ [Merged by Bors] - feat(algebra/order/smul): ordered_smul instances for ℕ and ℤ Aug 31, 2022
@bors bors bot closed this Aug 31, 2022
@bors bors bot deleted the nat_ordered_smul branch August 31, 2022 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) t-algebra Algebra (groups, rings, fields etc) t-order Order hierarchy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@YaelDillies @jcommelin @leanprover-community-bot-assistant