Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(order/bounded_order): The lattice of complemented elements #16267

Closed
wants to merge 8 commits into from

Conversation

YaelDillies
Copy link
Collaborator

@YaelDillies YaelDillies commented Aug 26, 2022

Define complementeds, the subtype of complemented elements, and show that it is a complemented bounded distributive lattice.


This is pretty tautological in itself. The motivation is when we get to Heyting algebras, as then complementeds is the right adjoint to the forgetful functor BoolAlg ⥤ HeytAlg.

Open in Gitpod

@YaelDillies YaelDillies added awaiting-review The author would like community review of the PR t-order Order hierarchy labels Aug 26, 2022
@mathlib-dependent-issues-bot mathlib-dependent-issues-bot added the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Aug 26, 2022
@mathlib-dependent-issues-bot mathlib-dependent-issues-bot removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Aug 29, 2022
@mathlib-dependent-issues-bot
Copy link
Collaborator

@Vierkantor Vierkantor self-assigned this Aug 30, 2022
@@ -1737,6 +1762,61 @@ instance : complemented_lattice αᵒᵈ :=

end complemented_lattice

-- TODO: Define as a sublattice?
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still not quite convinced that the predicate + subtype approach is the best way to go. Although dot notation is convenient, won't it cause a lot of annoyance transporting between is_complemented and complementeds, as it is already for is_unit?

With this setup, we definitely need some explicit maps between complementeds and is_complemented, along the lines of what we have for units and is_unit.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We now have quite a lot of experience with is_upper_set/upper_set, and it seems everything works smoothly. Of course there's some "morally duplicated" code, but IMO it's API making every use ever so less irritating.

I'm making complementeds into a reducible def for now because I'm not expecting to have a heavy enough use of it to justify duplicating subtype API.

src/order/bounded_order.lean Outdated Show resolved Hide resolved
src/order/bounded_order.lean Outdated Show resolved Hide resolved
@Vierkantor Vierkantor added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Aug 30, 2022
@YaelDillies YaelDillies added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jun 9, 2023
@github-actions github-actions bot added the modifies-synchronized-file This PR touches a files that has already been ported to mathlib4, and may need a synchronization PR. label Jun 9, 2023
Copy link
Collaborator

@Vierkantor Vierkantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors d+

@bors
Copy link

bors bot commented Jun 12, 2023

✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-bot-assistant leanprover-community-bot-assistant added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Jun 12, 2023
@YaelDillies
Copy link
Collaborator Author

bors merge

bors bot pushed a commit that referenced this pull request Jun 16, 2023
Define `complementeds`, the subtype of complemented elements, and show that it is a complemented bounded distributive lattice.
@bors
Copy link

bors bot commented Jun 16, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat(order/bounded_order): The lattice of complemented elements [Merged by Bors] - feat(order/bounded_order): The lattice of complemented elements Jun 16, 2023
@bors bors bot closed this Jun 16, 2023
@bors bors bot deleted the complementeds branch June 16, 2023 15:05
YaelDillies added a commit to leanprover-community/mathlib4 that referenced this pull request Jun 17, 2023
bors bot pushed a commit to leanprover-community/mathlib4 that referenced this pull request Jun 19, 2023
semorrison pushed a commit to leanprover-community/mathlib4 that referenced this pull request Jun 19, 2023
alexkeizer pushed a commit to leanprover-community/mathlib4 that referenced this pull request Jun 22, 2023
semorrison pushed a commit to leanprover-community/mathlib4 that referenced this pull request Jun 23, 2023
semorrison pushed a commit to leanprover-community/mathlib4 that referenced this pull request Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated The PR author may merge after reviewing final suggestions. modifies-synchronized-file This PR touches a files that has already been ported to mathlib4, and may need a synchronization PR. t-order Order hierarchy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants