Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - doc(measure_theory/integral): integrability docstrings #16269

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - doc(measure_theory/integral): integrability docstrings #16269

wants to merge 3 commits into from

Conversation

mcdoll
Copy link
Member

@mcdoll mcdoll commented Aug 27, 2022

This PR adds a few docstrings to make the conditions and more readable.

Open in Gitpod

@mcdoll
doc(measure_theory/integral): integrability docstrings
eea855f 
This PR adds a few docstrings to make the conditions and more readable.
@mcdoll mcdoll added the docs This PR is about documentation label Aug 27, 2022
@mcdoll mcdoll requested a review from ADedecker August 27, 2022 07:19
@RemyDegenne RemyDegenne added the awaiting-review The author would like community review of the PR label Aug 28, 2022
ADedecker
ADedecker reviewed Aug 31, 2022
View reviewed changes
Copy link
Member

@ADedecker ADedecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have nothing to add to Johan's comments, except that I would slightly prefer using symbols ∞ and -∞ over negative infinity and infinity

@ADedecker ADedecker added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Aug 31, 2022
@mcdoll @jcommelin
Apply suggestions from code review
ac07bd9 
Co-authored-by: Johan Commelin <johan@commelin.net>
@mcdoll mcdoll added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Aug 31, 2022
jcommelin
jcommelin approved these changes Aug 31, 2022
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-bot-assistant leanprover-community-bot-assistant added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Aug 31, 2022
bors bot pushed a commit that referenced this pull request Aug 31, 2022
@mcdoll
doc(measure_theory/integral): integrability docstrings (#16269)
87d8c4b 
This PR adds a few docstrings to make the conditions and more readable.
@bors
Copy link

bors bot commented Aug 31, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title doc(measure_theory/integral): integrability docstrings [Merged by Bors] - doc(measure_theory/integral): integrability docstrings Aug 31, 2022
@bors bors bot closed this Aug 31, 2022
@bors bors bot deleted the mcdoll/doc_improper_int branch August 31, 2022 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ADedecker ADedecker ADedecker left review comments

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
docs This PR is about documentation ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mcdoll @jcommelin @ADedecker @RemyDegenne @leanprover-community-bot-assistant