Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(linear_algebra/finite_dimensional): dim_add_le_dim_add_dim #16301

Closed
wants to merge 1 commit into from

Conversation

jsm28
Copy link
Collaborator

@jsm28 jsm28 commented Aug 29, 2022

Add a finrank version of a lemma that already exists for
module.rank. The proof is exactly the same as the proof of the
module.rank version, and, as with the previous
dim_sup_add_dim_inf_eq lemma that it uses, so is the name (but in
the submodule namespace in the case of the finrank versions).


Open in Gitpod

Add a `finrank` version of a lemma that already exists for
`module.rank`.  The proof is exactly the same as the proof of the
`module.rank` version, and, as with the previous
`dim_sup_add_dim_inf_eq` lemma that it uses, so is the name (but in
the `submodule` namespace in the case of the `finrank` versions).
@jsm28 jsm28 added easy < 20s of review time. See the lifecycle page for guidelines. awaiting-review The author would like community review of the PR t-algebra Algebra (groups, rings, fields etc) labels Aug 29, 2022
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-bot-assistant leanprover-community-bot-assistant added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Aug 30, 2022
bors bot pushed a commit that referenced this pull request Aug 30, 2022
…6301)

Add a `finrank` version of a lemma that already exists for
`module.rank`.  The proof is exactly the same as the proof of the
`module.rank` version, and, as with the previous
`dim_sup_add_dim_inf_eq` lemma that it uses, so is the name (but in
the `submodule` namespace in the case of the `finrank` versions).
@bors
Copy link

bors bot commented Aug 30, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(linear_algebra/finite_dimensional): dim_add_le_dim_add_dim [Merged by Bors] - feat(linear_algebra/finite_dimensional): dim_add_le_dim_add_dim Aug 30, 2022
@bors bors bot closed this Aug 30, 2022
@bors bors bot deleted the jsm28/finrank_dim_add_le_dim_add_dim branch August 30, 2022 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) t-algebra Algebra (groups, rings, fields etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants