Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(linear_algebra/affine_space/finite_dimensional): collinear lemmas, implicit arguments #16332

Closed
wants to merge 5 commits into from

Conversation

jsm28
Copy link
Collaborator

@jsm28 jsm28 commented Aug 31, 2022

Add more lemmas about collinear, and change existing iff lemmas
about collinear to follow usual mathlib conventions about implicit
arguments for such lemmas.


Open in Gitpod

…mas, implicit arguments

Add more lemmas about `collinear`, and change existing `iff` lemmas
about `collinear` to follow usual mathlib conventions about implicit
arguments for such lemmas.
@jsm28 jsm28 added awaiting-review The author would like community review of the PR t-algebra Algebra (groups, rings, fields etc) labels Aug 31, 2022
@jcommelin jcommelin added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Sep 21, 2022
@jsm28 jsm28 added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Sep 28, 2022
jsm28 added a commit that referenced this pull request Oct 4, 2022
…` lemmas

Add a further batch of lemmas about collinear sets of points, in
particular relating collinearity to any pair of distinct points in the
set.

---

This should be textually independent from #16332 (and there are no
dependencies of the lemmas on those in #16332), but, as was the case
with another PR, after one gets merged the other would need updating
for the change of argument implicitness for `collinear_iff_of_mem` in
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-bot-assistant leanprover-community-bot-assistant added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Oct 5, 2022
bors bot pushed a commit that referenced this pull request Oct 5, 2022
…mas, implicit arguments (#16332)

Add more lemmas about `collinear`, and change existing `iff` lemmas
about `collinear` to follow usual mathlib conventions about implicit
arguments for such lemmas.
@bors
Copy link

bors bot commented Oct 5, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(linear_algebra/affine_space/finite_dimensional): collinear lemmas, implicit arguments [Merged by Bors] - feat(linear_algebra/affine_space/finite_dimensional): collinear lemmas, implicit arguments Oct 5, 2022
@bors bors bot closed this Oct 5, 2022
@bors bors bot deleted the jsm28/collinear_subset_findim branch October 5, 2022 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) t-algebra Algebra (groups, rings, fields etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants