New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat(linear_algebra/affine_space/finite_dimensional): collinear
lemmas, implicit arguments
#16332
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mas, implicit arguments Add more lemmas about `collinear`, and change existing `iff` lemmas about `collinear` to follow usual mathlib conventions about implicit arguments for such lemmas.
jsm28
added
awaiting-review
The author would like community review of the PR
t-algebra
Algebra (groups, rings, fields etc)
labels
Aug 31, 2022
jcommelin
reviewed
Sep 21, 2022
jcommelin
added
awaiting-author
A reviewer has asked the author a question or requested changes
and removed
awaiting-review
The author would like community review of the PR
labels
Sep 21, 2022
jsm28
added
awaiting-review
The author would like community review of the PR
and removed
awaiting-author
A reviewer has asked the author a question or requested changes
labels
Sep 28, 2022
jsm28
added a commit
that referenced
this pull request
Oct 4, 2022
…` lemmas Add a further batch of lemmas about collinear sets of points, in particular relating collinearity to any pair of distinct points in the set. --- This should be textually independent from #16332 (and there are no dependencies of the lemmas on those in #16332), but, as was the case with another PR, after one gets merged the other would need updating for the change of argument implicitness for `collinear_iff_of_mem` in
jcommelin
approved these changes
Oct 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 🎉
bors merge
leanprover-community-bot-assistant
added
ready-to-merge
All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
and removed
awaiting-review
The author would like community review of the PR
labels
Oct 5, 2022
bors bot
pushed a commit
that referenced
this pull request
Oct 5, 2022
…mas, implicit arguments (#16332) Add more lemmas about `collinear`, and change existing `iff` lemmas about `collinear` to follow usual mathlib conventions about implicit arguments for such lemmas.
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
feat(linear_algebra/affine_space/finite_dimensional):
[Merged by Bors] - feat(linear_algebra/affine_space/finite_dimensional): Oct 5, 2022
collinear
lemmas, implicit argumentscollinear
lemmas, implicit arguments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ready-to-merge
All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
t-algebra
Algebra (groups, rings, fields etc)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add more lemmas about
collinear
, and change existingiff
lemmasabout
collinear
to follow usual mathlib conventions about implicitarguments for such lemmas.