[Merged by Bors] - fix(*): fix padding around notations #16333
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
digama0
added
the
awaiting-review
urkud
reviewed
Sep 1, 2022
| @@ -63,7 +63,7 @@ open_locale classical big_operators | |||
| linear_ordered_semiring, ordered_comm_semiring, canonically_ordered_comm_semiring, | |||
| has_sub, has_ordered_sub, has_div, inhabited]] | |||
| def nnreal := {r : ℝ // 0 ≤ r} | |||
| localized "notation (name := nnreal) ` ℝ≥0 ` := nnreal" in nnreal | |||
| localized "notation (name := nnreal) `ℝ≥0` := nnreal" in nnreal | |||
There was a problem hiding this comment.
What does (name := nnreal) mean? It is used here but not in nnrat notation.
There was a problem hiding this comment.
Localized notations require names now, see #16252. It looks like nnrat got merged around the same time and missed the memo.
|
✌️ digama0 can now approve this pull request. To approve and merge a pull request, simply reply with |
bryangingechen
added
awaiting-author
urkud
reviewed
Sep 5, 2022
|
bors r+ |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Sep 8, 2022
I noticed a bunch of issues around padding in mathport, so I went through and fixed all the padding issues I could find in mathlib. Co-authored-by: Yury G. Kudryashov <urkud@urkud.name>
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
bottine
pushed a commit
that referenced
this pull request
Sep 13, 2022
I noticed a bunch of issues around padding in mathport, so I went through and fixed all the padding issues I could find in mathlib. Co-authored-by: Yury G. Kudryashov <urkud@urkud.name>
b-mehta
pushed a commit
that referenced
this pull request
Sep 21, 2022
I noticed a bunch of issues around padding in mathport, so I went through and fixed all the padding issues I could find in mathlib. Co-authored-by: Yury G. Kudryashov <urkud@urkud.name>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed a bunch of issues around padding in mathport, so I went through and fixed all the padding issues I could find in mathlib.