chore(*): remove is_absolute_value #16340
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vierkantor
reviewed
Sep 1, 2022
mathlib-dependent-issues-bot
added
the
blocked-by-other-PR
bors bot
pushed a commit
that referenced
this pull request
Sep 24, 2022
Doing this this way round makes the refactor in #16340 much easier. I will follow up this PR with similar PRs for `padic_norm` and `padic_norm_e`. Co-authored-by: Eric Rodriguez <37984851+ericrbg@users.noreply.github.com>
mathlib-dependent-issues-bot
removed
the
blocked-by-other-PR
|
This PR/issue depends on:
|
bottine
pushed a commit
that referenced
this pull request
Sep 25, 2022
Doing this this way round makes the refactor in #16340 much easier. I will follow up this PR with similar PRs for `padic_norm` and `padic_norm_e`. Co-authored-by: Eric Rodriguez <37984851+ericrbg@users.noreply.github.com>
|
To be redone after the port, I assume? |
|
If I have time :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still a WIP - thoughts very welcome!