[Merged by Bors] - feat(probability/stopping): generalize mem_ℒp_stopped_value
#16369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RemyDegenne
added
the
awaiting-review
10 tasks
RemyDegenne
commented
Sep 4, 2022
Comment on lines
578
to
579
| (integrable.integrable_on (@integrable_stopped_value Ω ℕ _ _ _ _ _ _ _ _ _ | ||
| (hitting_is_stopping_time hsub.adapted measurable_set_Ici) hsub.integrable _ hitting_le)), |
There was a problem hiding this comment.
I need to add the @ because somehow none of the arguments can precisely indicate what the index type is and Lean guesses incorrectly Ω → ℕ instead of ℕ.
JasonKYi
reviewed
Sep 4, 2022
sgouezel
reviewed
Sep 7, 2022
| @@ -575,28 +575,28 @@ begin | |||
| have h := set_integral_ge_of_const_le (measurable_set_le measurable_const | |||
| (finset.measurable_range_sup'' (λ n _, (hsub.strongly_measurable n).measurable.le (𝒢.le n)))) | |||
| (measure_ne_top _ _) this | |||
| (integrable.integrable_on (integrable_stopped_value (hitting_is_stopping_time | |||
| hsub.adapted measurable_set_Ici) hsub.integrable hitting_le)), | |||
| (integrable.integrable_on (@integrable_stopped_value Ω ℕ _ _ _ _ _ _ _ _ _ | |||
There was a problem hiding this comment.
could you make the ℕ argument of integrable_stopped_value explicit, since it seems Lean has difficulties inferring it, to avoid using the @ version here and below?
|
✌️ RemyDegenne can now approve this pull request. To approve and merge a pull request, simply reply with |
leanprover-community-bot-assistant
added
delegated
RemyDegenne
commented
Sep 9, 2022
RemyDegenne
commented
Sep 9, 2022
RemyDegenne
commented
Sep 9, 2022
RemyDegenne
commented
Sep 9, 2022
|
bors r+ |
github-actions
bot
added
the
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Sep 9, 2022
Also rename many lemmas which had names `*_of_encodable` but took `countable` arguments since a recent PR which replaced all `encodable` by `countable` but did not touch the names. Co-authored-by: Rémy Degenne <remydegenne@gmail.com>
|
Build failed: |
|
bors r- |
RemyDegenne
removed
the
ready-to-merge
|
bors r+ |
github-actions
bot
added
the
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Sep 10, 2022
Also rename many lemmas which had names `*_of_encodable` but took `countable` arguments since a recent PR which replaced all `encodable` by `countable` but did not touch the names. Co-authored-by: Rémy Degenne <remydegenne@gmail.com> Co-authored-by: RemyDegenne <remydegenne@gmail.com>
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
mem_ℒp_stopped_valuemem_ℒp_stopped_value
bottine
pushed a commit
that referenced
this pull request
Sep 13, 2022
Also rename many lemmas which had names `*_of_encodable` but took `countable` arguments since a recent PR which replaced all `encodable` by `countable` but did not touch the names. Co-authored-by: Rémy Degenne <remydegenne@gmail.com> Co-authored-by: RemyDegenne <remydegenne@gmail.com>
b-mehta
pushed a commit
that referenced
this pull request
Sep 21, 2022
Also rename many lemmas which had names `*_of_encodable` but took `countable` arguments since a recent PR which replaced all `encodable` by `countable` but did not touch the names. Co-authored-by: Rémy Degenne <remydegenne@gmail.com> Co-authored-by: RemyDegenne <remydegenne@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also rename many lemmas which had names
*_of_encodablebut tookcountablearguments since a recent PR which replaced allencodablebycountablebut did not touch the names.