Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(topology/sheaves/abelian): category of sheaves is abelian #16403

Closed
wants to merge 17 commits into from
Closed

[Merged by Bors] - feat(topology/sheaves/abelian): category of sheaves is abelian #16403

wants to merge 17 commits into from

Conversation

jjaassoonn
Copy link
Collaborator

@jjaassoonn jjaassoonn commented Sep 6, 2022 •
edited by github-actions bot
Loading

@jjaassoonn jjaassoonn added blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. awaiting-CI The author would like to see what CI has to say before doing more work. labels Sep 6, 2022
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Sep 6, 2022
@mathlib-dependent-issues-bot mathlib-dependent-issues-bot removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Sep 14, 2022
@mathlib-dependent-issues-bot
Copy link
Collaborator

This PR/issue depends on:

@semorrison semorrison added awaiting-review The author would like community review of the PR t-category-theory Category theory labels Sep 15, 2022
@semorrison
Copy link
Collaborator

@jjaassoonn, PRs may not be seen by reviewers unless you add the label awaiting-review. I see you have a few unlabelled PRs. Could you go through and label them?

@riccardobrasca
Copy link
Member

Thanks!

bors d+

@bors
Copy link

bors bot commented Sep 23, 2022

✌️ jjaassoonn can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Sep 23, 2022
alreadydone
alreadydone reviewed Sep 23, 2022
View reviewed changes
src/topology/sheaves/abelian.lean Outdated Show resolved Hide resolved
src/topology/sheaves/abelian.lean Outdated Show resolved Hide resolved
src/topology/sheaves/abelian.lean Outdated Show resolved Hide resolved
src/topology/sheaves/abelian.lean Outdated Show resolved Hide resolved
src/topology/sheaves/abelian.lean

local attribute [instance] preserves_binary_biproducts_of_preserves_binary_products

instance presheaf_to_Sheaf_additive : (presheaf_to_Sheaf J D).additive :=
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't require [abelian D] right? Can you remove it from variables and add it only when necessary?

Does preadditive D suffice for this instance?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This actually needs abelian D assumption, because abelian D ensures Sheaf J D has binary products. So everything in this file actually needs abelian D

@jjaassoonn @alreadydone
Apply suggestions from code review
282c391 
Co-authored-by: Junyan Xu <junyanxumath@gmail.com>
@jjaassoonn jjaassoonn added the awaiting-CI The author would like to see what CI has to say before doing more work. label Sep 26, 2022
@jjaassoonn
Copy link
Collaborator Author

bors r+

@bors
Copy link

bors bot commented Sep 26, 2022

👎 Rejected by label

@riccardobrasca
Copy link
Member

I think you need to wait CI

@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Sep 26, 2022
@jjaassoonn
Copy link
Collaborator Author

bors r+

bors bot pushed a commit that referenced this pull request Sep 26, 2022
@jjaassoonn
feat(topology/sheaves/abelian): category of sheaves is abelian (#16403)
c561c79 
and that sheafification functor is additive
@bors
Copy link

bors bot commented Sep 26, 2022

Build failed (retrying...):

@jjaassoonn jjaassoonn mentioned this pull request Sep 26, 2022
Closed
bors bot pushed a commit that referenced this pull request Sep 26, 2022
@jjaassoonn
feat(topology/sheaves/abelian): category of sheaves is abelian (#16403)
d5e1961 
and that sheafification functor is additive
@bors
Copy link

bors bot commented Sep 26, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(topology/sheaves/abelian): category of sheaves is abelian [Merged by Bors] - feat(topology/sheaves/abelian): category of sheaves is abelian Sep 26, 2022
@bors bors bot closed this Sep 26, 2022
@bors bors bot deleted the jjaassoonn/sheaf_abelian branch September 26, 2022 15:46
@alreadydone alreadydone restored the jjaassoonn/sheaf_abelian branch September 26, 2022 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alreadydone alreadydone alreadydone left review comments

@riccardobrasca riccardobrasca riccardobrasca approved these changes

Assignees
No one assigned
Labels
delegated The PR author may merge after reviewing final suggestions. t-category-theory Category theory
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jjaassoonn @mathlib-dependent-issues-bot @semorrison @riccardobrasca @alreadydone