Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(analysis/normed/group/basic): add norm_multiset_sum_le #16419

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - feat(analysis/normed/group/basic): add norm_multiset_sum_le #16419

wants to merge 2 commits into from

Conversation

negiizhao
Copy link
Collaborator

Open in Gitpod

@negiizhao negiizhao added awaiting-review The author would like community review of the PR awaiting-CI The author would like to see what CI has to say before doing more work. labels Sep 7, 2022
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Sep 7, 2022
eric-wieser
eric-wieser approved these changes Sep 8, 2022
View reviewed changes
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the nnnorm version too? And maybe also the list versions if they're easy?

Otherwise, LGTM; bors d+

@negiizhao
Copy link
Collaborator Author

Seems we don't have list.le_sum_of_subadditive.

@eric-wieser
Copy link
Member

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Sep 8, 2022
bors bot pushed a commit that referenced this pull request Sep 8, 2022
@negiizhao
feat(analysis/normed/group/basic): add norm_multiset_sum_le (#16419)
75cc1ae
@bors
Copy link

bors bot commented Sep 9, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(analysis/normed/group/basic): add norm_multiset_sum_le [Merged by Bors] - feat(analysis/normed/group/basic): add norm_multiset_sum_le Sep 9, 2022
@bors bors bot closed this Sep 9, 2022
@bors bors bot deleted the FR_norm_multiset_sum_le branch September 9, 2022 00:43
bottine pushed a commit that referenced this pull request Sep 13, 2022
@negiizhao @bottine
feat(analysis/normed/group/basic): add norm_multiset_sum_le (#16419)
a1967f0
b-mehta pushed a commit that referenced this pull request Sep 21, 2022
@negiizhao @b-mehta
feat(analysis/normed/group/basic): add norm_multiset_sum_le (#16419)
ae4653d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser approved these changes

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@negiizhao @eric-wieser