Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(algebra/parity): Primes are not square #16430

Closed
wants to merge 2 commits into from

Conversation

YaelDillies
Copy link
Collaborator

and a few other basic results about is_square.


I split that off #12992 to ease reviewing and because the rest of the material there should be generalized to UFDs.

Open in Gitpod

@YaelDillies YaelDillies added awaiting-review The author would like community review of the PR t-algebra Algebra (groups, rings, fields etc) labels Sep 8, 2022
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-bot-assistant leanprover-community-bot-assistant added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Sep 9, 2022
bors bot pushed a commit that referenced this pull request Sep 9, 2022
and a few other basic results about `is_square`.
@bors
Copy link

bors bot commented Sep 9, 2022

Canceled.

@YaelDillies
Copy link
Collaborator Author

Sorry, just noticed a generalisation!

Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the generalization!

bors merge

bors bot pushed a commit that referenced this pull request Sep 10, 2022
and a few other basic results about `is_square`.
@bors
Copy link

bors bot commented Sep 10, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(algebra/parity): Primes are not square [Merged by Bors] - feat(algebra/parity): Primes are not square Sep 10, 2022
@bors bors bot closed this Sep 10, 2022
@bors bors bot deleted the prime_not_square branch September 10, 2022 21:04
bottine pushed a commit that referenced this pull request Sep 13, 2022
and a few other basic results about `is_square`.
b-mehta pushed a commit that referenced this pull request Sep 21, 2022
and a few other basic results about `is_square`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) t-algebra Algebra (groups, rings, fields etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants