Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(analysis/normed/group/quotient): transfer norm structures on quotients of groups to quotients of modules by submodules and of rings by ideals #16446

Closed
wants to merge 27 commits into from

Conversation

j-loreaux
Copy link
Collaborator

@j-loreaux j-loreaux commented Sep 9, 2022

This takes the existing norm structures on quotients of additive groups and transfers it along the definitional equality to quotients of modules by submodules and quotients of rings by ideals. In addition, this puts the extra norm structures on these objects where appropriate including complete_space, normed_space, semi_normed_comm_ring, normed_comm_ring and normed_algebra.


Open in Gitpod

@j-loreaux j-loreaux added awaiting-review The author would like community review of the PR awaiting-CI The author would like to see what CI has to say before doing more work. t-analysis Analysis (normed *, calculus) labels Sep 9, 2022
@mathlib-dependent-issues-bot mathlib-dependent-issues-bot added the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Sep 9, 2022
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Sep 9, 2022
@dupuisf
Copy link
Collaborator

dupuisf commented Sep 15, 2022

Could you add a little bit of documentation about this in the file-level docstring as well? Looks good otherwise.

bors d+

@bors
Copy link

bors bot commented Sep 15, 2022

✌️ j-loreaux can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Sep 15, 2022
@j-loreaux
Copy link
Collaborator Author

bors r+

bors bot pushed a commit that referenced this pull request Sep 15, 2022
…tients of groups to quotients of modules by submodules and of rings by ideals (#16446)

This takes the existing norm structures on quotients of additive groups and transfers it along the definitional equality to quotients of modules by submodules and quotients of rings by ideals. In addition, this puts the extra norm structures on these objects where appropriate including `complete_space`, `normed_space`, `semi_normed_comm_ring`, `normed_comm_ring` and `normed_algebra`.

- [x] depends on: #16368
@bors
Copy link

bors bot commented Sep 15, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(analysis/normed/group/quotient): transfer norm structures on quotients of groups to quotients of modules by submodules and of rings by ideals [Merged by Bors] - feat(analysis/normed/group/quotient): transfer norm structures on quotients of groups to quotients of modules by submodules and of rings by ideals Sep 15, 2022
@bors bors bot closed this Sep 15, 2022
@bors bors bot deleted the j-loreaux/normed-ring-quotient branch September 15, 2022 16:26
bors bot pushed a commit that referenced this pull request Sep 16, 2022
…ansform is a bijective isometry for C⋆-algebras over ℂ (#16488)

- [x] depends on: #16451
- [x] depends on: #16438
- [x] depends on: #16368
- [x] depends on: #16303
- [x] depends on: #16446
- [x] depends on: #16448
b-mehta pushed a commit that referenced this pull request Sep 21, 2022
…tients of groups to quotients of modules by submodules and of rings by ideals (#16446)

This takes the existing norm structures on quotients of additive groups and transfers it along the definitional equality to quotients of modules by submodules and quotients of rings by ideals. In addition, this puts the extra norm structures on these objects where appropriate including `complete_space`, `normed_space`, `semi_normed_comm_ring`, `normed_comm_ring` and `normed_algebra`.

- [x] depends on: #16368
b-mehta pushed a commit that referenced this pull request Sep 21, 2022
…ansform is a bijective isometry for C⋆-algebras over ℂ (#16488)

- [x] depends on: #16451
- [x] depends on: #16438
- [x] depends on: #16368
- [x] depends on: #16303
- [x] depends on: #16446
- [x] depends on: #16448
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated The PR author may merge after reviewing final suggestions. t-analysis Analysis (normed *, calculus)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants