Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(analysis/special_functions/pow, set_theory/*): positivity extension for powers #16462

Closed
wants to merge 10 commits into from

Conversation

YaelDillies
Copy link
Collaborator

Add the following positivity extensions to handle powers:

  • positivity_rpow for real powers
  • positivity_opow for ordinal powers
  • positivity_cardinal_pow for cardinal powers

Open in Gitpod

@YaelDillies YaelDillies added awaiting-review The author would like community review of the PR t-meta Tactics, attributes or user commands t-algebra Algebra (groups, rings, fields etc) t-order Order hierarchy labels Sep 11, 2022
src/algebra/field_power.lean Outdated Show resolved Hide resolved
src/number_theory/frobenius_number.lean Outdated Show resolved Hide resolved
@Vierkantor Vierkantor self-assigned this Sep 21, 2022
@Vierkantor Vierkantor added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Sep 21, 2022
@YaelDillies YaelDillies added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Sep 21, 2022
Copy link
Collaborator

@Vierkantor Vierkantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors r+

@leanprover-community-bot-assistant leanprover-community-bot-assistant added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Sep 22, 2022
@YaelDillies
Copy link
Collaborator Author

Sorry, that will likely conflict with #16141 for stupid reasons (the tests)!

@Vierkantor
Copy link
Collaborator

Oops!

bors r-
bors d+

@bors
Copy link

bors bot commented Sep 22, 2022

✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@bors
Copy link

bors bot commented Sep 22, 2022

Canceled.

@github-actions github-actions bot added the delegated The PR author may merge after reviewing final suggestions. label Sep 22, 2022
@YaelDillies
Copy link
Collaborator Author

Indeed, it was the tests' fault.

bors merge

bors bot pushed a commit that referenced this pull request Sep 22, 2022
…nsion for powers (#16462)

Add the following `positivity` extensions to handle powers:
* `positivity_rpow` for real powers
* `positivity_opow` for ordinal powers
* `positivity_cardinal_pow` for cardinal powers
@bors
Copy link

bors bot commented Sep 22, 2022

This PR was included in a batch that was canceled, it will be automatically retried

bors bot pushed a commit that referenced this pull request Sep 23, 2022
…nsion for powers (#16462)

Add the following `positivity` extensions to handle powers:
* `positivity_rpow` for real powers
* `positivity_opow` for ordinal powers
* `positivity_cardinal_pow` for cardinal powers
@bors
Copy link

bors bot commented Sep 23, 2022

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Sep 23, 2022
…nsion for powers (#16462)

Add the following `positivity` extensions to handle powers:
* `positivity_rpow` for real powers
* `positivity_opow` for ordinal powers
* `positivity_cardinal_pow` for cardinal powers
@bors
Copy link

bors bot commented Sep 23, 2022

Build failed (retrying...):

@kmill
Copy link
Collaborator

kmill commented Sep 23, 2022

Tests seem to be an issue here again

bors r-

@bors
Copy link

bors bot commented Sep 23, 2022

Canceled.

@kmill kmill added the awaiting-author A reviewer has asked the author a question or requested changes label Sep 23, 2022
@YaelDillies
Copy link
Collaborator Author

Must've messed up the merge...

bors merge

bors bot pushed a commit that referenced this pull request Sep 23, 2022
…nsion for powers (#16462)

Add the following `positivity` extensions to handle powers:
* `positivity_rpow` for real powers
* `positivity_opow` for ordinal powers
* `positivity_cardinal_pow` for cardinal powers
@bors
Copy link

bors bot commented Sep 23, 2022

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Sep 23, 2022
…nsion for powers (#16462)

Add the following `positivity` extensions to handle powers:
* `positivity_rpow` for real powers
* `positivity_opow` for ordinal powers
* `positivity_cardinal_pow` for cardinal powers
@bors
Copy link

bors bot commented Sep 23, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(analysis/special_functions/pow, set_theory/*): positivity extension for powers [Merged by Bors] - feat(analysis/special_functions/pow, set_theory/*): positivity extension for powers Sep 23, 2022
@bors bors bot closed this Sep 23, 2022
@bors bors bot deleted the positivity_pow branch September 23, 2022 11:39
bottine pushed a commit that referenced this pull request Sep 25, 2022
…nsion for powers (#16462)

Add the following `positivity` extensions to handle powers:
* `positivity_rpow` for real powers
* `positivity_opow` for ordinal powers
* `positivity_cardinal_pow` for cardinal powers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-author A reviewer has asked the author a question or requested changes delegated The PR author may merge after reviewing final suggestions. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) t-algebra Algebra (groups, rings, fields etc) t-meta Tactics, attributes or user commands t-order Order hierarchy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants