Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(linear_algebra/{basis, determinant, orientation}): determinant of adjust_to_orientation of a basis #16476

Closed
wants to merge 7 commits into from

Conversation

hrmacbeth
Copy link
Member

@hrmacbeth hrmacbeth commented Sep 12, 2022

Performing the operation adjust_to_orientation on a basis either preserves the determinant with respect to that basis, or negates it.

Formalized as part of the Sphere Eversion project.


Open in Gitpod

@hrmacbeth hrmacbeth added the awaiting-CI The author would like to see what CI has to say before doing more work. label Sep 12, 2022
@hrmacbeth hrmacbeth added this to In progress in Sphere eversion project via automation Sep 12, 2022
hrmacbeth and others added 3 commits September 12, 2022 11:16
Co-authored-by: Johan Commelin <johan@commelin.net>
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Sep 12, 2022
@hrmacbeth hrmacbeth added the awaiting-review The author would like community review of the PR label Sep 12, 2022
@semorrison semorrison added the t-algebra Algebra (groups, rings, fields etc) label Sep 14, 2022
Copy link
Collaborator

@sgouezel sgouezel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+
Thanks!

@leanprover-community-bot-assistant leanprover-community-bot-assistant added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Sep 30, 2022
bors bot pushed a commit that referenced this pull request Sep 30, 2022
…f `adjust_to_orientation` of a basis (#16476)

Performing the operation `adjust_to_orientation` on a basis either preserves the determinant with respect to that basis, or negates it.

Formalized as part of the Sphere Eversion project.
@bors
Copy link

bors bot commented Sep 30, 2022

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Sep 30, 2022
…f `adjust_to_orientation` of a basis (#16476)

Performing the operation `adjust_to_orientation` on a basis either preserves the determinant with respect to that basis, or negates it.

Formalized as part of the Sphere Eversion project.
@bors
Copy link

bors bot commented Oct 1, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(linear_algebra/{basis, determinant, orientation}): determinant of adjust_to_orientation of a basis [Merged by Bors] - feat(linear_algebra/{basis, determinant, orientation}): determinant of adjust_to_orientation of a basis Oct 1, 2022
@bors bors bot closed this Oct 1, 2022
Sphere eversion project automation moved this from In progress to Done Oct 1, 2022
@bors bors bot deleted the det_adjust_to_orientation branch October 1, 2022 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) t-algebra Algebra (groups, rings, fields etc)
Development

Successfully merging this pull request may close these issues.

None yet

5 participants