[Merged by Bors] - chore(topology/constructions): deduplicate #16505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urkud
added
awaiting-review
eric-wieser
reviewed
Sep 17, 2022
Comment on lines
-202
to
+205
| have hf : continuous (λ p : E × E, f p.1 p.2), from | ||
| (continuous_fst.const_smul _).add (continuous_snd.const_smul _), | ||
| show f x y ∈ closure s, from | ||
| mem_closure_of_continuous2 hf hx hy (λ x' hx' y' hy', subset_closure | ||
| (hs hx' hy' ha hb hab)) | ||
| have hf : continuous (function.uncurry f), | ||
| from (continuous_fst.const_smul _).add (continuous_snd.const_smul _), | ||
| show f x y ∈ closure s, | ||
| from map_mem_closure₂ hf hx hy (λ x' hx' y' hy', hs hx' hy' ha hb hab) |
There was a problem hiding this comment.
This makes it look like mem_closure_of_continuous2 was a stronger lemma as it didn't need as strong an assumption. Is my reading correct?
Presumably the difference in strength has no mathematical content, so
bors d+
There was a problem hiding this comment.
Indeed, these lemmas differ by closure_closure and all applications of mem_closure_of_continuous2 did not use this extra generality.
|
✌️ urkud can now approve this pull request. To approve and merge a pull request, simply reply with |
|
bors merge |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Sep 17, 2022
* rename `mem_closure_of_continuous` to `set.maps_to.closure_left`, move near `map_mem_closure`; * merge `map_mem_closure2` and `mem_closure_of_continuous2` into `map_mem_closure₂`; * fix&golf some proofs broken by these changes.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
b-mehta
pushed a commit
that referenced
this pull request
Sep 21, 2022
* rename `mem_closure_of_continuous` to `set.maps_to.closure_left`, move near `map_mem_closure`; * merge `map_mem_closure2` and `mem_closure_of_continuous2` into `map_mem_closure₂`; * fix&golf some proofs broken by these changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mem_closure_of_continuoustoset.maps_to.closure_left, move nearmap_mem_closure;map_mem_closure2andmem_closure_of_continuous2intomap_mem_closure₂;