Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(archive/birthday): improve birthday problem #16528

Closed
wants to merge 3 commits into from

Conversation

ericrbg
Copy link
Collaborator

@ericrbg ericrbg commented Sep 16, 2022

This adds a measure-theoretic interpretation of the birthday problem; not yet the one with independent uniform random variables, but some form of a step in that direction.

It also removes a misleading statement from the YAML to make it clearer that card_embedding_eq is not all the work done on the Birthday problem on mathlib. cc @digama0


Open in Gitpod

@ericrbg ericrbg added awaiting-CI The author would like to see what CI has to say before doing more work. awaiting-review The author would like community review of the PR t-measure-probability Measure theory / Probability theory labels Sep 16, 2022
Copy link
Member

@JasonKYi JasonKYi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Sep 16, 2022
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors d+

archive/100-theorems-list/93_birthday_problem.lean Outdated Show resolved Hide resolved
@bors
Copy link

bors bot commented Sep 17, 2022

✌️ ericrbg can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-bot-assistant leanprover-community-bot-assistant added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Sep 17, 2022
Co-authored-by: Johan Commelin <johan@commelin.net>
@ericrbg
Copy link
Collaborator Author

ericrbg commented Sep 18, 2022

bors r+

bors bot pushed a commit that referenced this pull request Sep 18, 2022
This adds a measure-theoretic interpretation of the birthday problem; not yet the one with independent uniform random variables, but some form of a step in that direction.

It also removes a misleading statement from the YAML to make it clearer that `card_embedding_eq` is not all the work done on the Birthday problem on mathlib. cc @digama0



Co-authored-by: Eric Rodriguez <37984851+ericrbg@users.noreply.github.com>
@bors
Copy link

bors bot commented Sep 18, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(archive/birthday): improve birthday problem [Merged by Bors] - feat(archive/birthday): improve birthday problem Sep 18, 2022
@bors bors bot closed this Sep 18, 2022
@bors bors bot deleted the ericrbg/birthday_plus branch September 18, 2022 13:45
b-mehta pushed a commit that referenced this pull request Sep 21, 2022
This adds a measure-theoretic interpretation of the birthday problem; not yet the one with independent uniform random variables, but some form of a step in that direction.

It also removes a misleading statement from the YAML to make it clearer that `card_embedding_eq` is not all the work done on the Birthday problem on mathlib. cc @digama0



Co-authored-by: Eric Rodriguez <37984851+ericrbg@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated The PR author may merge after reviewing final suggestions. t-measure-probability Measure theory / Probability theory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants