[Merged by Bors] - feat(data/set/basic): Refactor and additions of sep lemmas #16566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linesthatinterlace
added
awaiting-review
linesthatinterlace
requested review from
YaelDillies,
b-mehta and
eric-wieser
urkud
reviewed
Sep 20, 2022
urkud
added
awaiting-author
linesthatinterlace
added
awaiting-review
|
@urkud Thank for that - very helpful review. See what you think now. I'm not sure all the new lemmas should be simp - what do you think? |
github-actions
bot
removed
the
awaiting-CI
eric-wieser
reviewed
Sep 21, 2022
eric-wieser
reviewed
Sep 21, 2022
urkud
reviewed
Sep 23, 2022
Co-authored-by: Yury G. Kudryashov <urkud@urkud.name>
|
Thanks! 🎉 |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Sep 28, 2022
Add and refactor sep lemmas. Co-authored-by: Yaël Dillies <[yael.dillies@gmail.com](mailto:yael.dillies@gmail.com)> Co-authored-by: Wrenna Robson <34025592+linesthatinterlace@users.noreply.github.com>
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add and refactor sep lemmas.
Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
In #16314, a number of sep lemmas were added. It's more appropriate that these enter a separate PR, so I've prepared this. I've mostly taken what @YaelDillies had, and tweaked it slightly.