Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - doc(metric_space/basic): modify doc for metric spaces adding pseudo metric spaces #16577

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - doc(metric_space/basic): modify doc for metric spaces adding pseudo metric spaces #16577

wants to merge 1 commit into from

Conversation

faenuccio
Copy link
Collaborator

The doc preceeding the pseudo_metric_space instance spoke only about metric spaces. I have added the pseudo_metric version.

Open in Gitpod

@faenuccio faenuccio added easy < 20s of review time. See the lifecycle page for guidelines. awaiting-review The author would like community review of the PR docs This PR is about documentation t-topology Topological spaces, uniform spaces, metric spaces, filters labels Sep 21, 2022
@sgouezel
Copy link
Collaborator

bors r+
Thanks

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Sep 21, 2022
@bryangingechen bryangingechen changed the title doc(metric_space/basic.doc): modify doc for metric spaces adding pseudo metric spaces doc(metric_space/basic): modify doc for metric spaces adding pseudo metric spaces Sep 21, 2022
bors bot pushed a commit that referenced this pull request Sep 21, 2022
@faenuccio
doc(metric_space/basic): modify doc for metric spaces adding pseudo m…
b153991 
…etric spaces (#16577)

The doc preceeding the `pseudo_metric_space` instance spoke only about `metric spaces`. I have added the `pseudo_metric` version.
@bors
Copy link

bors bot commented Sep 21, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title doc(metric_space/basic): modify doc for metric spaces adding pseudo metric spaces [Merged by Bors] - doc(metric_space/basic): modify doc for metric spaces adding pseudo metric spaces Sep 21, 2022
@bors bors bot closed this Sep 21, 2022
@bors bors bot deleted the doc_metric_spaces branch September 21, 2022 17:14
b-mehta pushed a commit that referenced this pull request Sep 21, 2022
@faenuccio @b-mehta
doc(metric_space/basic): modify doc for metric spaces adding pseudo m…
0e18561 
…etric spaces (#16577)

The doc preceeding the `pseudo_metric_space` instance spoke only about `metric spaces`. I have added the `pseudo_metric` version.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-loreaux j-loreaux Awaiting requested review from j-loreaux

@riccardobrasca riccardobrasca Awaiting requested review from riccardobrasca

Assignees
No one assigned
Labels
docs This PR is about documentation easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) t-topology Topological spaces, uniform spaces, metric spaces, filters
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@faenuccio @sgouezel