Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(combinatorics/catalan): Connection between Catalan numbers and number of trees #16583

Closed
wants to merge 52 commits into from

Conversation

prakol16
Copy link
Collaborator

@prakol16 prakol16 commented Sep 21, 2022

Shows that the number of binary trees with n nodes is the nth Catalan number.


Open in Gitpod

@prakol16 prakol16 added WIP Work in progress awaiting-CI The author would like to see what CI has to say before doing more work. labels Sep 21, 2022
@mathlib-dependent-issues-bot mathlib-dependent-issues-bot added the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Sep 21, 2022
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Sep 21, 2022
@prakol16 prakol16 added awaiting-review The author would like community review of the PR and removed WIP Work in progress labels Sep 22, 2022
Copy link
Member

@hrmacbeth hrmacbeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I can't comment on the PR it depends on, but the main PR looks good to me.

@mathlib-dependent-issues-bot mathlib-dependent-issues-bot removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Jan 23, 2023
@mathlib-dependent-issues-bot
Copy link
Collaborator

Copy link
Collaborator

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you merge master to reduce the diff?

src/combinatorics/catalan.lean Outdated Show resolved Hide resolved
src/combinatorics/catalan.lean Show resolved Hide resolved
src/combinatorics/catalan.lean Show resolved Hide resolved
src/combinatorics/catalan.lean Outdated Show resolved Hide resolved
src/combinatorics/catalan.lean Outdated Show resolved Hide resolved
prakol16 and others added 3 commits February 1, 2023 17:29
Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
Copy link
Collaborator

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's in good shape. Thanks!

maintainer merge

@github-actions
Copy link

github-actions bot commented Feb 3, 2023

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

/-- A finset of all trees with `n` nodes. See `mem_trees_of_nodes_eq` -/
def trees_of_num_nodes_eq : ℕ → finset (tree unit)
| 0 := {nil}
| (n+1) := (finset.nat.antidiagonal n).attach.bUnion $ λ ijh,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YaelDillies, can you see a way to use disj_Union here instead?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind, this can wait till a follow-up

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought about it but it doesn't seem obvious at all.

Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@leanprover-community-bot-assistant leanprover-community-bot-assistant added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Feb 8, 2023
bors bot pushed a commit that referenced this pull request Feb 8, 2023
…umber of trees (#16583)

Shows that the number of binary trees with `n` nodes is the  `n`th Catalan number.
@bors
Copy link

bors bot commented Feb 8, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(combinatorics/catalan): Connection between Catalan numbers and number of trees [Merged by Bors] - feat(combinatorics/catalan): Connection between Catalan numbers and number of trees Feb 8, 2023
@bors bors bot closed this Feb 8, 2023
@bors bors bot deleted the catalan_numbers_trees branch February 8, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants