Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(topology/algebra/group): discrete subgroup acts properly discontinuously #16593

Closed
wants to merge 4 commits into from

Conversation

hrmacbeth
Copy link
Member

@hrmacbeth hrmacbeth commented Sep 22, 2022

A discrete subgroup of a topological group acts properly discontinuously on the left and on the right. Here discrete means finite intersection with any compact subset.

Co-authored-by: Alex Kontorovich 58564076+AlexKontorovich@users.noreply.github.com


Open in Gitpod

@hrmacbeth hrmacbeth added awaiting-review The author would like community review of the PR awaiting-CI The author would like to see what CI has to say before doing more work. t-topology Topological spaces, uniform spaces, metric spaces, filters labels Sep 22, 2022
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Sep 22, 2022
src/topology/algebra/group.lean Outdated Show resolved Hide resolved
@ocfnash ocfnash added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Oct 7, 2022
@hrmacbeth hrmacbeth added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Oct 10, 2022
Comment on lines 1035 to 1036
/-- A discrete subgroup of a topological group `G` acts on `G` properly discontinuously on the left.
-/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is worth avoiding the word "discrete" here since there are two possible meanings. How about:

Suggested change
/-- A discrete subgroup of a topological group `G` acts on `G` properly discontinuously on the left.
-/
/-- Given a subgroup `S` of topological group `G`, if `S ∩ K` is finite for all compact `K`, then `S` acts on `G` properly discontinuously on the left.
-/

The second meaning is that one might mean S gets the discrete topology. Of course they're related: I think the following is true:

example {α : Type*} [topological_space α] [locally_compact_space α] [t2_space α]
  (s : set α) (hs : is_closed s) :
  tendsto (coe : s → α) filter.cofinite (cocompact α) ↔ discrete_topology s :=

but missing from Mathlib.

See also

lemma tendsto_zmultiples_hom_cofinite {a : ℝ} (ha : a ≠ 0) :
vs
instance {E : Type*} [normed_add_comm_group E] [normed_space ℚ E] (e : E) :

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually would like to leave in the word "discrete", because it's clearly related, and someone might search mathlib using that term. How about a phrasing which makes clear that this is not necessarily the standard use, like

A subgroup S of topological group G acts on G properly discontinuously on the left, if it is discrete in the sense that S ∩ K is finite for all compact K. (See also discrete_topology.)

And indeed, someone should figure out and Lean-ify what the relationship between the concepts is.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect; go for it.

Copy link
Collaborator

@ocfnash ocfnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One remark about terminology in comments but otherwise LGTM.

bors d+

@bors
Copy link

bors bot commented Oct 10, 2022

✌️ hrmacbeth can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-bot-assistant leanprover-community-bot-assistant added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Oct 10, 2022
@hrmacbeth hrmacbeth requested a review from a team as a code owner October 10, 2022 15:30
@hrmacbeth
Copy link
Member Author

bors r+

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Oct 10, 2022
bors bot pushed a commit that referenced this pull request Oct 10, 2022
…inuously (#16593)

A discrete subgroup of a topological group acts properly discontinuously on the left and on the right.  Here discrete means finite intersection with any compact subset.

Co-authored-by: Alex Kontorovich <58564076+AlexKontorovich@users.noreply.github.com>
@bors
Copy link

bors bot commented Oct 10, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(topology/algebra/group): discrete subgroup acts properly discontinuously [Merged by Bors] - feat(topology/algebra/group): discrete subgroup acts properly discontinuously Oct 10, 2022
@bors bors bot closed this Oct 10, 2022
@bors bors bot deleted the discrete_subgroup_properly_discontinuous branch October 10, 2022 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated The PR author may merge after reviewing final suggestions. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) t-topology Topological spaces, uniform spaces, metric spaces, filters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants