Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(linear_algebra/quadratic_form/basic): algebraic lemmas about bilin_form.to_quadratic_form #16616

Closed
wants to merge 1 commit into from

Conversation

eric-wieser
Copy link
Member

@eric-wieser eric-wieser commented Sep 23, 2022

Following the usual pattern, we defined the bundle additive morphism so that we can copy across the salient lemmas about sums.

The polar_to_quadratic_form lemma in the diff was an existing lemma that has just been moved below the new semiring section.


Open in Gitpod

…quadratic_form

Following the usual pattern, we defined the bundled additive morphism so that we can copy across the salient lemmas about sums.
@eric-wieser eric-wieser added easy < 20s of review time. See the lifecycle page for guidelines. awaiting-review The author would like community review of the PR t-algebra Algebra (groups, rings, fields etc) labels Sep 23, 2022
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-bot-assistant leanprover-community-bot-assistant added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Sep 30, 2022
bors bot pushed a commit that referenced this pull request Sep 30, 2022
…lin_form.to_quadratic_form` (#16616)

Following the usual pattern, we defined the bundle additive morphism so that we can copy across the salient lemmas about sums.

The `polar_to_quadratic_form` lemma in the diff was an existing lemma that has just been moved below the new `semiring` section.
@bors
Copy link

bors bot commented Sep 30, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(linear_algebra/quadratic_form/basic): algebraic lemmas about bilin_form.to_quadratic_form [Merged by Bors] - feat(linear_algebra/quadratic_form/basic): algebraic lemmas about bilin_form.to_quadratic_form Sep 30, 2022
@bors bors bot closed this Sep 30, 2022
@bors bors bot deleted the eric-wieser/quadratic_form-lemmas branch September 30, 2022 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) t-algebra Algebra (groups, rings, fields etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants