-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat(category_theory/groupoid): simplify groupoid.inv to category_theory.inv #16624
Conversation
⟨⟨groupoid.inv f, groupoid.comp_inv f, groupoid.inv_comp f⟩⟩ | ||
|
||
@[simp] lemma groupoid.inv_eq_inv (f : X ⟶ Y) : groupoid.inv f = inv f := | ||
is_iso.eq_inv_of_hom_inv_id $ groupoid.comp_inv f |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rwbarton, @semorrison, or @dwarn: This seems like a reasonable simp normal form to me, but I'd like to run this design decision by at least one of you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest that we try this out. If it causes trouble, we remove it from the simp set.
bors merge
…ory.inv (#16624) Add simp lemma `groupoid.inv_eq_inv` to simplify `groupoid.inv` to `category_theory.inv` (which uses the `is_iso` instance) to gain access to the developed API around `category_theory.inv`. This isn't a defeq though so I can imagine sometimes we may want to `simp [-groupoid.inv_eq_inv]`, but most of the times this simp lemma makes things smoother.
Pull request successfully merged into master. Build succeeded: |
Add simp lemma
groupoid.inv_eq_inv
to simplifygroupoid.inv
tocategory_theory.inv
(which uses theis_iso
instance) to gain access to the developed API aroundcategory_theory.inv
. This isn't a defeq though so I can imagine sometimes we may want tosimp [-groupoid.inv_eq_inv]
, but most of the times this simp lemma makes things smoother.Allows to solve the following lemmas needed for #16611 by simp: