Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - fix(tactic/positivity + test): instantiate meta-variables and add a test #16647

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - fix(tactic/positivity + test): instantiate meta-variables and add a test #16647

wants to merge 2 commits into from

Conversation

adomani
Copy link
Collaborator

@adomani adomani commented Sep 26, 2022 •
edited

Fix an issue with positivity reported by @YaelDillies here.

For the fix, it seems that instantiating meta-variables is enough.

Open in Gitpod

@adomani adomani changed the title chore(tactic/positivity + test): instantiate meta-variables and add a test fix(tactic/positivity + test): instantiate meta-variables and add a test Sep 26, 2022
YaelDillies
YaelDillies approved these changes Sep 26, 2022
View reviewed changes
Copy link
Collaborator

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

test/positivity.lean Outdated Show resolved Hide resolved
@adomani adomani added bug awaiting-review The author would like community review of the PR t-meta Tactics, attributes or user commands labels Sep 26, 2022
@fpvandoorn
Copy link
Member

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Sep 27, 2022
bors bot pushed a commit that referenced this pull request Sep 27, 2022
@adomani
fix(tactic/positivity + test): instantiate meta-variables and add a t…
6f9edf5 
…est (#16647)

Fix an issue with `positivity` reported by @YaelDillies [here](https://leanprover.zulipchat.com/#narrow/stream/239415-metaprogramming-.2F-tactics/topic/New.20tactic.3A.20.60positivity.60/near/300639970).

For the fix, it seems that instantiating meta-variables is enough.
@bors
Copy link

bors bot commented Sep 27, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title fix(tactic/positivity + test): instantiate meta-variables and add a test [Merged by Bors] - fix(tactic/positivity + test): instantiate meta-variables and add a test Sep 27, 2022
@bors bors bot closed this Sep 27, 2022
@bors bors bot deleted the adomani_inst_pos branch September 27, 2022 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YaelDillies YaelDillies YaelDillies approved these changes

Assignees
No one assigned
Labels
bug ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) t-meta Tactics, attributes or user commands
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@adomani @fpvandoorn @YaelDillies