Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - refactor(algebra/group/with_one): inv_one_class and related instances #16697

Closed
wants to merge 1 commit into from

Conversation

jsm28
Copy link
Collaborator

@jsm28 jsm28 commented Sep 29, 2022

Add instances for neg_zero_class, inv_one_class and div_inv_one_monoid for with_zero, and inv_one_class for with_one, under appropriate conditions.


Open in Gitpod

Add instances for `neg_zero_class`, `inv_one_class` and
`div_inv_one_monoid` for `with_zero`, and `inv_one_class` for
`with_one`, under appropriate conditions.
@jsm28 jsm28 added awaiting-review The author would like community review of the PR awaiting-CI The author would like to see what CI has to say before doing more work. t-algebra Algebra (groups, rings, fields etc) labels Sep 29, 2022
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Sep 29, 2022
@ocfnash
Copy link
Collaborator

ocfnash commented Oct 5, 2022

Thanks

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Oct 5, 2022
bors bot pushed a commit that referenced this pull request Oct 5, 2022
…es (#16697)

Add instances for `neg_zero_class`, `inv_one_class` and `div_inv_one_monoid` for `with_zero`, and `inv_one_class` for `with_one`, under appropriate conditions.
@bors
Copy link

bors bot commented Oct 5, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title refactor(algebra/group/with_one): inv_one_class and related instances [Merged by Bors] - refactor(algebra/group/with_one): inv_one_class and related instances Oct 5, 2022
@bors bors bot closed this Oct 5, 2022
@bors bors bot deleted the jsm28/inv_neg_with_zero_one branch October 5, 2022 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) t-algebra Algebra (groups, rings, fields etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants