[Merged by Bors] - feat(algebra/{hom,ring}): extra coercion lemmas for {mul,add,ring}_equiv
#16725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…quiv`
This PR adds more lemmas for the coercion of `refl` and `trans` of `{mul,add,ring}_equiv` to other types of maps. In particular, it ensures these types come with:
* `coe_{type}_refl` and `coe_{type}_trans` where `type` ranges over the types of bundled maps that the equivs inherit from
* `self_trans_symm` and `symm_trans_self`
* `coe_trans`
Of course, it would be great if we figured out some generic way of stating all these results so we wouldn't have to go through and add all these lemmas.
Vierkantor
added
awaiting-review
Vierkantor
commented
Oct 1, 2022
github-actions
bot
removed
the
awaiting-CI
leanprover-community-bot-assistant
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Oct 6, 2022
…quiv` (#16725) This PR adds more lemmas for the coercion of `refl` and `trans` of `{mul,add,ring}_equiv` to other types of maps. In particular, it ensures these types come with: * `coe_{type}_refl` and `coe_{type}_trans` where `type` ranges over the types of bundled maps that the equivs inherit from * `self_trans_symm` and `symm_trans_self` * `coe_trans` Of course, it would be great if we figured out some generic way of stating all these results so we wouldn't have to go through and add all these lemmas. Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
{mul,add,ring}_equiv{mul,add,ring}_equiv
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds more lemmas for the coercion of
reflandtransof{mul,add,ring}_equivto other types of maps. In particular, it ensures these types come with:coe_{type}_reflandcoe_{type}_transwheretyperanges over the types of bundled maps that the equivs inherit fromself_trans_symmandsymm_trans_selfcoe_transOf course, it would be great if we figured out some generic way of stating all these results so we wouldn't have to go through and add all these lemmas.