Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - refactor(ring_theory/class_group): redefine class_group without fraction field #16727

Closed
wants to merge 15 commits into from

Commits on Sep 29, 2022

  1. feat(algebra/hom/group): simp lemmas for applying generic morphism …

    …coercions
    
    There are a bunch of random specific versions of these lemmas floating around, which can be made generic to apply to all `one_hom_class`/`mul_hom_class`/`monoid_hom_class` instances. Compare existing `ring_hom.coe_coe`.
    Vierkantor committed Sep 29, 2022
    Copy the full SHA
    df795c8 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2022

  1. feat(algebra/{hom,ring}): extra coercion lemmas for `{mul,add,ring}_e…

    …quiv`
    
    This PR adds more lemmas for the coercion of `refl` and `trans` of `{mul,add,ring}_equiv` to other types of maps. In particular, it ensures these types come with:
     * `coe_{type}_refl` and `coe_{type}_trans` where `type` ranges over the types of bundled maps that the equivs inherit from
     * `self_trans_symm` and `symm_trans_self`
     * `coe_trans`
    
    Of course, it would be great if we figured out some generic way of stating all these results so we wouldn't have to go through and add all these lemmas.
    Vierkantor committed Sep 30, 2022
    Copy the full SHA
    d0ef044 View commit details
    Browse the repository at this point in the history
  2. feat(algebra/{hom,ring}): extra coercion lemmas for `{mul,add,ring}_e…

    …quiv`
    
    This PR adds more lemmas for the coercion of `refl` and `trans` of `{mul,add,ring}_equiv` to other types of maps. In particular, it ensures these types come with:
     * `coe_{type}_refl` and `coe_{type}_trans` where `type` ranges over the types of bundled maps that the equivs inherit from
     * `self_trans_symm` and `symm_trans_self`
     * `coe_trans`
    
    Of course, it would be great if we figured out some generic way of stating all these results so we wouldn't have to go through and add all these lemmas.
    Vierkantor committed Sep 30, 2022
    Copy the full SHA
    e42e155 View commit details
    Browse the repository at this point in the history
  3. feat(group_theory/quotient_group): congr for lifting a isomorphism …

    …to subgroup isomorphism
    Vierkantor committed Sep 30, 2022
    Copy the full SHA
    f5f8a87 View commit details
    Browse the repository at this point in the history
  4. to_additive

    Vierkantor committed Sep 30, 2022
    Copy the full SHA
    bcea040 View commit details
    Browse the repository at this point in the history
  5. Copy the full SHA
    f40977c View commit details
    Browse the repository at this point in the history
  6. Fix usages of class_group

    Vierkantor committed Sep 30, 2022
    Copy the full SHA
    2a8e7b3 View commit details
    Browse the repository at this point in the history
  7. Delete lint call

    Vierkantor committed Sep 30, 2022
    Copy the full SHA
    1b655c0 View commit details
    Browse the repository at this point in the history
  8. Fix missing variable

    Vierkantor committed Sep 30, 2022
    Copy the full SHA
    3b7d831 View commit details
    Browse the repository at this point in the history
  9. Copy the full SHA
    d67ec3b View commit details
    Browse the repository at this point in the history
  10. Copy the full SHA
    bda9673 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2022

  1. Unneeded parameter

    Vierkantor committed Oct 1, 2022
    Copy the full SHA
    7036314 View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    9d95100 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2022

  1. Copy the full SHA
    86706ef View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2022

  1. Copy the full SHA
    abd6342 View commit details
    Browse the repository at this point in the history