Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(probability/variance): introduce ℝ≥0∞-valued variance #16730

Closed
wants to merge 20 commits into from
Closed

[Merged by Bors] - feat(probability/variance): introduce ℝ≥0∞-valued variance #16730

wants to merge 20 commits into from

Conversation

JasonKYi
Copy link
Member

This PR introduces ℝ≥0∞-valued variance and define the real-valued variance in terms of it.

See here for Zulip discussion here.

Open in Gitpod

@JasonKYi JasonKYi added awaiting-review The author would like community review of the PR awaiting-CI The author would like to see what CI has to say before doing more work. t-measure-probability Measure theory / Probability theory labels Sep 30, 2022
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Sep 30, 2022
@RemyDegenne RemyDegenne added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Oct 4, 2022
@JasonKYi JasonKYi added awaiting-review The author would like community review of the PR awaiting-CI The author would like to see what CI has to say before doing more work. and removed awaiting-author A reviewer has asked the author a question or requested changes labels Oct 4, 2022
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Oct 4, 2022
RemyDegenne
RemyDegenne reviewed Oct 5, 2022
View reviewed changes
src/data/real/nnreal.lean Outdated Show resolved Hide resolved
src/probability/ident_distrib.lean Outdated Show resolved Hide resolved
src/probability/variance.lean Outdated Show resolved Hide resolved
src/probability/variance.lean Outdated Show resolved Hide resolved
src/probability/variance.lean Outdated Show resolved Hide resolved
src/probability/variance.lean Show resolved Hide resolved
src/probability/variance.lean Outdated Show resolved Hide resolved
@RemyDegenne RemyDegenne added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Oct 5, 2022
@JasonKYi JasonKYi removed the awaiting-author A reviewer has asked the author a question or requested changes label Oct 5, 2022
@JasonKYi JasonKYi added awaiting-review The author would like community review of the PR awaiting-CI The author would like to see what CI has to say before doing more work. labels Oct 5, 2022
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Oct 6, 2022
RemyDegenne
RemyDegenne approved these changes Oct 7, 2022
View reviewed changes
Copy link
Collaborator

@RemyDegenne RemyDegenne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!
bors d+

src/analysis/normed/group/basic.lean Outdated Show resolved Hide resolved
src/probability/moments.lean Outdated Show resolved Hide resolved
src/probability/variance.lean Outdated Show resolved Hide resolved
src/probability/variance.lean Outdated Show resolved Hide resolved
@bors
Copy link

bors bot commented Oct 7, 2022

✌️ JasonKYi can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-bot-assistant leanprover-community-bot-assistant added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Oct 7, 2022
JasonKYi and others added 2 commits October 7, 2022 12:48
@JasonKYi @RemyDegenne
Apply suggestions from code review
c20d916 
Co-authored-by: Rémy Degenne <remydegenne@gmail.com>
@JasonKYi
fix
f610e44
@JasonKYi
Copy link
Member Author

JasonKYi commented Oct 7, 2022

Thanks for the reviews!
bors r+

bors bot pushed a commit that referenced this pull request Oct 7, 2022
@JasonKYi
feat(probability/variance): introduce ℝ≥0∞-valued variance (#16730)
f5a136f 
This PR introduces `ℝ≥0∞`-valued variance and define the real-valued variance in terms of it.
@bors
Copy link

bors bot commented Oct 7, 2022

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Oct 8, 2022
@JasonKYi
feat(probability/variance): introduce ℝ≥0∞-valued variance (#16730)
85453a2 
This PR introduces `ℝ≥0∞`-valued variance and define the real-valued variance in terms of it.
@bors
Copy link

bors bot commented Oct 8, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(probability/variance): introduce ℝ≥0∞-valued variance [Merged by Bors] - feat(probability/variance): introduce ℝ≥0∞-valued variance Oct 8, 2022
@bors bors bot closed this Oct 8, 2022
@bors bors bot deleted the JasonKYi/cheb branch October 8, 2022 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RemyDegenne RemyDegenne RemyDegenne approved these changes

Assignees
No one assigned
Labels
delegated The PR author may merge after reviewing final suggestions. t-measure-probability Measure theory / Probability theory
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JasonKYi @RemyDegenne @leanprover-community-bot-assistant