Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - refactor(data/list/count): review API, add lemmas #16736

Closed
wants to merge 3 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Sep 30, 2022

  • add list.countp_join, list.countp_map, list.countp_mono_left,
    list.countp_congr, and list.count_join;
  • add @[simp] attrs to list.countp_eq_zero,
    list.countp_eq_length, list.count_eq_zero, and
    list.count_eq_length;
  • golf the proofs of list.count_bind, list.count_map_of_injective,
    and list.count_le_count_map.

Open in Gitpod

* add `list.countp_join`, `list.countp_map`, `list.countp_le_of_imp`,
  `list.countp_congr`, and `list.count_join`;
* add `@[simp]` attrs to `list.countp_eq_zero`,
  `list.countp_eq_length`, `list.count_eq_zero`, and
  `list.count_eq_length`;
* golf the proofs of `list.count_bind`, `list.count_map_of_injective`,
  and `list.count_le_count_map`.
@urkud urkud added the awaiting-review The author would like community review of the PR label Sep 30, 2022
Copy link
Member

@fpvandoorn fpvandoorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

one renaming suggestion (feel free to ignore)

bors d+

src/data/list/count.lean Outdated Show resolved Hide resolved
@bors
Copy link

bors bot commented Oct 3, 2022

✌️ urkud can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-bot-assistant leanprover-community-bot-assistant added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Oct 3, 2022
@urkud
Copy link
Member Author

urkud commented Oct 4, 2022

bors merge

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Oct 4, 2022
bors bot pushed a commit that referenced this pull request Oct 4, 2022
* add `list.countp_join`, `list.countp_map`, `list.countp_mono_left`,
  `list.countp_congr`, and `list.count_join`;
* add `@[simp]` attrs to `list.countp_eq_zero`,
  `list.countp_eq_length`, `list.count_eq_zero`, and
  `list.count_eq_length`;
* golf the proofs of `list.count_bind`, `list.count_map_of_injective`,
  and `list.count_le_count_map`.
@bors
Copy link

bors bot commented Oct 4, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title refactor(data/list/count): review API, add lemmas [Merged by Bors] - refactor(data/list/count): review API, add lemmas Oct 4, 2022
@bors bors bot closed this Oct 4, 2022
@bors bors bot deleted the YK-list-count branch October 4, 2022 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated The PR author may merge after reviewing final suggestions. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants