[Merged by Bors] - fix({ tactic/fin_cases + test/interval_cases }): add focus1 and a test
#16752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adomani
added
awaiting-review
hrmacbeth
added
the
modifies-tactic-syntax
|
Adding "modifies tactic syntax" just in case. It only modifies the behaviour of A tactics expert should review, but LGTM. |
adomani
changed the title
focus1 and a testfocus1 and a test
adomani
changed the title
focus1 and a testfocus1 and a test
|
LGTM bors merge |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Oct 3, 2022
…est (#16752) Fix [this bug](https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/interval_cases.20bug), reported by @hrmacbeth. The current solution is to move the `focus1` to `fin_cases_at`, instead of relying on `fin_cases` and `interval_cases` to call `focus1`. Having `interval_cases` wrapped in `focus1` is the reason for this PR. An older (compiling) solution was to just use `focus1` inside `interval_cases`, but calling it in `fin_cases_at` seems more stable. The link above is to a Zulip discussion with more details.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
focus1 and a testfocus1 and a test
eric-wieser
added
the
hacktoberfest-accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix this bug, reported by @hrmacbeth.
The current solution is to move the
focus1tofin_cases_at, instead of relying onfin_casesandinterval_casesto callfocus1. Havinginterval_caseswrapped infocus1is the reason for this PR.An older (compiling) solution was to just use
focus1insideinterval_cases, but calling it infin_cases_atseems more stable.The link above is to a Zulip discussion with more details.