Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(data/(d)finsupp): well-foundedness of lexicographic and product orders #16772

Closed
wants to merge 39 commits into from

Conversation

alreadydone
Copy link
Collaborator

@alreadydone alreadydone commented Oct 3, 2022

condition on domain finsupp/dfinsupp function/pi
arbitrary (prod) / has well_founded_gt (lex) 0 is a bottom elem in codomain (e.g. canonically_ordered) + well_founded_lt invalid
finite (prod) / finite with linear_order (lex) codomain has well_founded_lt same as (d)finsupp
  • (prod) means the product order and (lex) means the lexicographic order.

All results are provided in two forms whenever possible: a general form where the relations can be arbitrary (not the (<) of a preorder, or not even transitive, etc.) and a specialized form provided as well_founded_lt instances where the (d)finsupp/pi type (or their lex type synonyms) carries a natural (<).


Open in Gitpod

@alreadydone alreadydone added the awaiting-review The author would like community review of the PR label Oct 3, 2022
@alreadydone alreadydone added t-order Order hierarchy blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. labels Oct 3, 2022
Copy link
Collaborator

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with this PR overall but there is a lot going on and I would feel more comfortable with a second pair of eyes reviewing it (@eric-wieser maybe?). But I recognize I'm probably the reviewer the closest to this kind of maths...

@alreadydone
Copy link
Collaborator Author

@eric-wieser @YaelDillies Any further comments?

Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
@YaelDillies
Copy link
Collaborator

maintainer merge

@github-actions
Copy link

github-actions bot commented Nov 4, 2022

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@Vierkantor
Copy link
Collaborator

Since the build hasn't finished I'll delegate just in case you need to fix it.

bors d+

@bors
Copy link

bors bot commented Nov 4, 2022

✌️ alreadydone can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Nov 4, 2022
@YaelDillies
Copy link
Collaborator

Seems to have been forborsgotten!

@alreadydone
Copy link
Collaborator Author

bors r+

bors bot pushed a commit that referenced this pull request Nov 5, 2022
…orders (#16772)

| condition on domain                 | finsupp/dfinsupp                                                  | function/pi        |
|
@bors
Copy link

bors bot commented Nov 5, 2022

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Nov 5, 2022
…orders (#16772)

| condition on domain                 | finsupp/dfinsupp                                                  | function/pi        |
|
@bors
Copy link

bors bot commented Nov 5, 2022

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Nov 5, 2022
…orders (#16772)

| condition on domain                 | finsupp/dfinsupp                                                  | function/pi        |
|
@bors
Copy link

bors bot commented Nov 5, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(data/(d)finsupp): well-foundedness of lexicographic and product orders [Merged by Bors] - feat(data/(d)finsupp): well-foundedness of lexicographic and product orders Nov 5, 2022
@bors bors bot closed this Nov 5, 2022
@bors bors bot deleted the well_founded_dfinsupp branch November 5, 2022 03:36
@eric-wieser eric-wieser added the hacktoberfest-accepted Without this label hacktoberfest is scared off by bors label Nov 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated The PR author may merge after reviewing final suggestions. hacktoberfest-accepted Without this label hacktoberfest is scared off by bors t-order Order hierarchy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants