New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat(data/(d)finsupp): well-foundedness of lexicographic and product orders #16772
Conversation
instances can't be automatically inferred
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy with this PR overall but there is a lot going on and I would feel more comfortable with a second pair of eyes reviewing it (@eric-wieser maybe?). But I recognize I'm probably the reviewer the closest to this kind of maths...
@eric-wieser @YaelDillies Any further comments? |
Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
maintainer merge |
🚀 Pull request has been placed on the maintainer queue by YaelDillies. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 🎉
bors merge
Since the build hasn't finished I'll delegate just in case you need to fix it. bors d+ |
✌️ alreadydone can now approve this pull request. To approve and merge a pull request, simply reply with |
Seems to have been |
bors r+ |
…orders (#16772) | condition on domain | finsupp/dfinsupp | function/pi | |
Build failed (retrying...): |
…orders (#16772) | condition on domain | finsupp/dfinsupp | function/pi | |
Build failed (retrying...): |
…orders (#16772) | condition on domain | finsupp/dfinsupp | function/pi | |
Pull request successfully merged into master. Build succeeded: |
All results are provided in two forms whenever possible: a general form where the relations can be arbitrary (not the (<) of a preorder, or not even transitive, etc.) and a specialized form provided as
well_founded_lt
instances where the (d)finsupp/pi type (or theirlex
type synonyms) carries a natural (<).