Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(algebra/big_operators): dvd_sum #1679

Merged
merged 7 commits into from
Nov 13, 2019
Merged

feat(algebra/big_operators): dvd_sum #1679

merged 7 commits into from
Nov 13, 2019

Conversation

ChrisHughes24
Copy link
Member

@ChrisHughes24 ChrisHughes24 commented Nov 12, 2019

TO CONTRIBUTORS:

Make sure you have:

  • reviewed and applied the coding style: coding, naming
  • reviewed and applied the documentation requirements
  • for tactics:
  • make sure definitions and lemmas are put in the right files
  • make sure definitions and lemmas are not redundant

If this PR is related to a discussion on Zulip, please include a link in the discussion.

For reviewers: code review check list

@@ -1526,6 +1526,14 @@ by rw [h, prod_append, prod_cons, mul_left_comm]; exact dvd_mul_right _ _
@[simp] theorem sum_const_nat (m n : ℕ) : sum (list.repeat m n) = m * n :=
by induction n; [refl, simp only [*, repeat_succ, sum_cons, nat.mul_succ, add_comm]]

theorem dvd_sum [comm_semiring α] {a} {l : list α} (h : ∀ x ∈ l, a ∣ x) : a ∣ l.sum :=
begin
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have expected a term-mode pattern matching proof from Chris... I'm happy to see you are coming over to the light side of the force. [/joking]

@robertylewis robertylewis added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Nov 13, 2019
@mergify mergify bot merged commit 3bb2b5c into master Nov 13, 2019
@ChrisHughes24 ChrisHughes24 deleted the dvd_sum branch March 2, 2020 12:17
anrddh pushed a commit to anrddh/mathlib that referenced this pull request May 15, 2020
* feat(data/multiset): dvd_sum

* feat(algebra/big_operators): dvd_sum

* fix build

* fix build

* fix build
anrddh pushed a commit to anrddh/mathlib that referenced this pull request May 16, 2020
* feat(data/multiset): dvd_sum

* feat(algebra/big_operators): dvd_sum

* fix build

* fix build

* fix build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants