[Merged by Bors] - feat(algebra/gcd_monoid/finset): Generalize finset.gcd_image
#16795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YaelDillies
added
awaiting-review
|
Thanks! bors d+ |
|
✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with |
github-actions
bot
added
delegated
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Oct 5, 2022
`finset.gcd_image` and `finset.gcd_eq_gcd_image` were unnecessarily assuming `[is_idempotent α gcd]`. Remove that assumption and add the corresponding `finset.lcm` lemmas.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
finset.gcd_imagefinset.gcd_image
eric-wieser
added
the
hacktoberfest-accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
finset.gcd_imageandfinset.gcd_eq_gcd_imagewere unnecessarily assuming[is_idempotent α gcd]. Remove that assumption and add the correspondingfinset.lcmlemmas.Those lemmas now apply to
ℤand polynomials.