[Merged by Bors] - chore(data/pfunctor/univariate): remove use of h_generalize
#16839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to help with the port we remove all uses of the tactic `h_generalize`, there is only one in fact
alexjbest
added
awaiting-review
github-actions
bot
removed
the
awaiting-CI
leanprover-community-bot-assistant
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Oct 7, 2022
to help with the port we remove all uses of the tactic `h_generalize`, there is only one in fact
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Oct 8, 2022
to help with the port we remove all uses of the tactic `h_generalize`, there is only one in fact
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
h_generalizeh_generalize
alexjbest
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Oct 10, 2022
In leanprover-community/mathlib#16839 I removed all uses of the `h_generalize` tactics in mathlib, so that we can ignore it for the purposes of a working port
bors bot
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Oct 10, 2022
In leanprover-community/mathlib#16839 I removed all uses of the `h_generalize` tactics in mathlib, so that we can ignore it for the purposes of a working port of mathlib Due dilligence reveals that it is used a few times in flypitch, https://github.com/flypitch/flypitch/blob/aea5800db1f4cce53fc4a113711454b27388ecf8/src/forcing.lean, so maybe a more ambitious mathport would cover it, but it certainly seems low priority to me
eric-wieser
added
the
hacktoberfest-accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to help with the port we remove all uses of the tactic
h_generalize, there is only one in fact