Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(algebraic_geometry/prime_spectrum/basic): intersection of localisations #16860

Closed
wants to merge 21 commits into from
Closed

[Merged by Bors] - feat(algebraic_geometry/prime_spectrum/basic): intersection of localisations #16860

wants to merge 21 commits into from

Conversation

Multramate
Copy link
Collaborator

@Multramate Multramate commented Oct 8, 2022 •
edited by github-actions bot

@Multramate Multramate added awaiting-review The author would like community review of the PR awaiting-CI The author would like to see what CI has to say before doing more work. t-algebra Algebra (groups, rings, fields etc) t-algebraic-geometry Algebraic geometry labels Oct 8, 2022
@alreadydone alreadydone mentioned this pull request Oct 8, 2022
Closed
8 tasks
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Oct 8, 2022
erdOne
erdOne reviewed Oct 8, 2022
View reviewed changes
src/ring_theory/dedekind_domain/ideal.lean Outdated Show resolved Hide resolved
src/algebraic_geometry/prime_spectrum/basic.lean Outdated Show resolved Hide resolved
src/algebraic_geometry/prime_spectrum/basic.lean Outdated Show resolved Hide resolved
@Multramate Multramate requested review from a team as code owners October 10, 2022 14:02
@jcommelin jcommelin removed the request for review from a team October 10, 2022 14:22
jcommelin
jcommelin reviewed Oct 11, 2022
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you add the maximal spectrum, I think it needs to come with a lot of API about its relation to the prime spectrum: at a minimum the inclusion map. Maybe also the characterisation of the image as the subset of closed points.

At a later stage, maybe the Zariski topology on the maximal spectrum should be added, and then of course the continuity of the inclusion map.

src/algebraic_geometry/prime_spectrum/basic.lean Outdated Show resolved Hide resolved
@jcommelin jcommelin added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Oct 11, 2022
@Multramate
Copy link
Collaborator Author

Multramate commented Oct 11, 2022 •
edited

If you add the maximal spectrum, I think it needs to come with a lot of API about its relation to the prime spectrum: at a minimum the inclusion map. Maybe also the characterisation of the image as the subset of closed points.

At a later stage, maybe the Zariski topology on the maximal spectrum should be added, and then of course the continuity of the inclusion map.

Yes, I plan to make a basic API right after this, but on a separate PR so as to not cloud this one - is that fine? I also plan to refactor them into a separate file in the same folder called maximal_spectrum.

@jcommelin
Copy link
Member

Is the content of this PR urgent? If not, then I would prefer that you swap the order of those two PRs.

Multramate and others added 2 commits October 11, 2022 02:43
@Multramate @jcommelin
Fix typo
11fa5f5 
Co-authored-by: Johan Commelin <johan@commelin.net>
@Multramate
Define maximal spectrum
3f3de3c
@Multramate
Copy link
Collaborator Author

Multramate commented Oct 11, 2022 •
edited

Is the content of this PR urgent? If not, then I would prefer that you swap the order of those two PRs.

I made a basic PR for the maximal spectrum, but I'm not sure if the Zariski topology definition is ideal here.

@Multramate Multramate added awaiting-review The author would like community review of the PR blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. and removed awaiting-author A reviewer has asked the author a question or requested changes labels Oct 11, 2022
@mathlib-dependent-issues-bot mathlib-dependent-issues-bot removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Oct 11, 2022
@mathlib-dependent-issues-bot mathlib-dependent-issues-bot removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Oct 12, 2022
@mathlib-dependent-issues-bot mathlib-dependent-issues-bot added the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Oct 12, 2022
@jcommelin jcommelin added the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Oct 13, 2022
@Multramate Multramate added awaiting-review The author would like community review of the PR awaiting-CI The author would like to see what CI has to say before doing more work. and removed awaiting-author A reviewer has asked the author a question or requested changes blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. labels Oct 13, 2022
@mathlib-dependent-issues-bot
Copy link
Collaborator

This PR/issue depends on:

@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Oct 14, 2022
@Multramate Multramate removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Oct 14, 2022
erdOne
erdOne reviewed Oct 16, 2022
View reviewed changes
Copy link
Member

@erdOne erdOne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that the comment applies to all three lemmas.

src/algebraic_geometry/prime_spectrum/maximal.lean Outdated Show resolved Hide resolved
src/algebraic_geometry/prime_spectrum/maximal.lean Outdated Show resolved Hide resolved
src/algebraic_geometry/prime_spectrum/maximal.lean Outdated Show resolved Hide resolved
@erdOne
Copy link
Member

erdOne commented Oct 17, 2022

Thanks!
maintainer merge

@github-actions
Copy link

🚀 Pull request has been placed on the maintainer queue by erdOne.

Vierkantor
Vierkantor approved these changes Oct 17, 2022
View reviewed changes
Copy link
Collaborator

@Vierkantor Vierkantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors merge

@leanprover-community-bot-assistant leanprover-community-bot-assistant added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Oct 17, 2022
bors bot pushed a commit that referenced this pull request Oct 17, 2022
@Multramate
feat(algebraic_geometry/prime_spectrum/basic): intersection of locali…
5f17f4d 
…sations (#16860)

- [x] depends on: #16905 [define maximal spectrum]
- [x] depends on: #16920 [refactor height one spectrum]
@bors
Copy link

bors bot commented Oct 17, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(algebraic_geometry/prime_spectrum/basic): intersection of localisations [Merged by Bors] - feat(algebraic_geometry/prime_spectrum/basic): intersection of localisations Oct 17, 2022
@bors bors bot closed this Oct 17, 2022
@bors bors bot deleted the localization_infi_eq_bot branch October 17, 2022 13:11
@eric-wieser eric-wieser added the hacktoberfest-accepted Without this label hacktoberfest is scared off by bors label Oct 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alreadydone alreadydone alreadydone left review comments

@jcommelin jcommelin jcommelin left review comments

@erdOne erdOne erdOne left review comments

@Vierkantor Vierkantor Vierkantor approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted Without this label hacktoberfest is scared off by bors ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) t-algebra Algebra (groups, rings, fields etc) t-algebraic-geometry Algebraic geometry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@Multramate @jcommelin @mathlib-dependent-issues-bot @erdOne @Vierkantor @alreadydone @eric-wieser @leanprover-community-bot-assistant