Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore(algebra/ring/basic): postpone unneeded imports #16863

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - chore(algebra/ring/basic): postpone unneeded imports #16863

wants to merge 1 commit into from

Conversation

semorrison
Copy link
Collaborator

No rearranging of content, just deferring some imports that aren't actually needed until later files.

Open in Gitpod

@semorrison semorrison added easy < 20s of review time. See the lifecycle page for guidelines. awaiting-review The author would like community review of the PR awaiting-CI The author would like to see what CI has to say before doing more work. t-algebra Algebra (groups, rings, fields etc) labels Oct 8, 2022
jcommelin
jcommelin approved these changes Oct 8, 2022
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@bors
Copy link

bors bot commented Oct 8, 2022

👎 Rejected by label

@leanprover-community-bot-assistant leanprover-community-bot-assistant added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Oct 8, 2022
@jcommelin
Copy link
Member

bors d+

@bors
Copy link

bors bot commented Oct 8, 2022

✌️ semorrison can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-CI The author would like to see what CI has to say before doing more work. labels Oct 8, 2022
@semorrison
Copy link
Collaborator Author

bors merge

bors bot pushed a commit that referenced this pull request Oct 9, 2022
@semorrison
chore(algebra/ring/basic): postpone unneeded imports (#16863)
b8d96d7 
No rearranging of content, just deferring some imports that aren't actually needed until later files.



Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
@bors
Copy link

bors bot commented Oct 9, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(algebra/ring/basic): postpone unneeded imports [Merged by Bors] - chore(algebra/ring/basic): postpone unneeded imports Oct 9, 2022
@bors bors bot closed this Oct 9, 2022
@bors bors bot deleted the semorrison/algebra_ring_basic_imports branch October 9, 2022 03:38
@eric-wieser eric-wieser added the hacktoberfest-accepted Without this label hacktoberfest is scared off by bors label Oct 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
delegated The PR author may merge after reviewing final suggestions. easy < 20s of review time. See the lifecycle page for guidelines. hacktoberfest-accepted Without this label hacktoberfest is scared off by bors ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) t-algebra Algebra (groups, rings, fields etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@semorrison @jcommelin @eric-wieser @leanprover-community-bot-assistant