Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore(algebra/ring/basic): move results about regular elements #16865

Closed
wants to merge 4 commits into from
Closed

[Merged by Bors] - chore(algebra/ring/basic): move results about regular elements #16865

wants to merge 4 commits into from

Conversation

semorrison
Copy link
Collaborator

Open in Gitpod

@semorrison semorrison added awaiting-review The author would like community review of the PR awaiting-CI The author would like to see what CI has to say before doing more work. t-algebra Algebra (groups, rings, fields etc) labels Oct 8, 2022
jcommelin
jcommelin approved these changes Oct 8, 2022
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

If CI passes, please remove the label awaiting-CI and merge this yourself, by adding a comment bors r+.

bors d+

@bors
Copy link

bors bot commented Oct 8, 2022

✌️ semorrison can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-bot-assistant leanprover-community-bot-assistant added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Oct 8, 2022
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Oct 8, 2022
@semorrison
Copy link
Collaborator Author

bors merge

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Oct 9, 2022
bors bot pushed a commit that referenced this pull request Oct 9, 2022
@semorrison
chore(algebra/ring/basic): move results about regular elements (#16865)
8fb5c46 


Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
@bors
Copy link

bors bot commented Oct 9, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(algebra/ring/basic): move results about regular elements [Merged by Bors] - chore(algebra/ring/basic): move results about regular elements Oct 9, 2022
@bors bors bot closed this Oct 9, 2022
@bors bors bot deleted the semorrison/algebra_ring_basic_regular branch October 9, 2022 11:15
@eric-wieser eric-wieser added the hacktoberfest-accepted Without this label hacktoberfest is scared off by bors label Oct 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
delegated The PR author may merge after reviewing final suggestions. hacktoberfest-accepted Without this label hacktoberfest is scared off by bors ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) t-algebra Algebra (groups, rings, fields etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@semorrison @jcommelin @eric-wieser @leanprover-community-bot-assistant