Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(ring_theory/integral_closure): Generalize is_integral_algebra_map_iff to noncommutative setting. #16880

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - feat(ring_theory/integral_closure): Generalize is_integral_algebra_map_iff to noncommutative setting. #16880

wants to merge 1 commit into from

Conversation

erdOne
Copy link
Member

@erdOne erdOne commented Oct 9, 2022

Open in Gitpod

@erdOne erdOne added easy < 20s of review time. See the lifecycle page for guidelines. awaiting-review The author would like community review of the PR t-algebra Algebra (groups, rings, fields etc) labels Oct 9, 2022
jcommelin
jcommelin approved these changes Oct 10, 2022
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-bot-assistant leanprover-community-bot-assistant added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Oct 10, 2022
bors bot pushed a commit that referenced this pull request Oct 10, 2022
@erdOne
feat(ring_theory/integral_closure): Generalize `is_integral_algebra_m…
b381419 
…ap_iff` to noncommutative setting. (#16880)
@bors
Copy link

bors bot commented Oct 10, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(ring_theory/integral_closure): Generalize is_integral_algebra_map_iff to noncommutative setting. [Merged by Bors] - feat(ring_theory/integral_closure): Generalize is_integral_algebra_map_iff to noncommutative setting. Oct 10, 2022
@bors bors bot closed this Oct 10, 2022
@bors bors bot deleted the erdOne-generalize_integral_closure_lemma branch October 10, 2022 08:47
@eric-wieser eric-wieser added the hacktoberfest-accepted Without this label hacktoberfest is scared off by bors label Oct 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
easy < 20s of review time. See the lifecycle page for guidelines. hacktoberfest-accepted Without this label hacktoberfest is scared off by bors ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) t-algebra Algebra (groups, rings, fields etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@erdOne @jcommelin @eric-wieser @leanprover-community-bot-assistant