Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(probability/borel_cantelli): the second Borel-Cantelli lemma #16882

Closed
wants to merge 31 commits into from
Closed

[Merged by Bors] - feat(probability/borel_cantelli): the second Borel-Cantelli lemma #16882

wants to merge 31 commits into from

Conversation

JasonKYi
Copy link
Member

@JasonKYi JasonKYi commented Oct 9, 2022 •
edited by github-actions bot

@JasonKYi JasonKYi added WIP Work in progress t-measure-probability Measure theory / Probability theory labels Oct 9, 2022
@JasonKYi JasonKYi added awaiting-review The author would like community review of the PR awaiting-CI The author would like to see what CI has to say before doing more work. and removed WIP Work in progress labels Oct 9, 2022
@JasonKYi JasonKYi added WIP Work in progress and removed awaiting-review The author would like community review of the PR labels Oct 9, 2022
@JasonKYi JasonKYi mentioned this pull request Oct 13, 2022
Closed
@JasonKYi JasonKYi requested a review from a team as a code owner October 15, 2022 11:50
@JasonKYi
Copy link
Member Author

@RemyDegenne I tried to golf using your indep_sets_pi_Union_Inter_of_disjoint but (a) it requires is_probability_measure while the original did not and (b) the proof ended up longer :p I have kept it as is for now

@JasonKYi JasonKYi added awaiting-review The author would like community review of the PR and removed WIP Work in progress labels Oct 15, 2022
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Oct 15, 2022
@RemyDegenne RemyDegenne mentioned this pull request Oct 16, 2022
Closed
1 task
@RemyDegenne RemyDegenne added the awaiting-author A reviewer has asked the author a question or requested changes label Oct 27, 2022
@JasonKYi JasonKYi added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Oct 28, 2022
@JasonKYi
Copy link
Member Author

JasonKYi commented Oct 28, 2022 •
edited

There's a few independence lemmas about the natural filtration in the Borel Cantelli file (e.g. Indep_fun.indep_comap_succ_natural). Should I perhaps import the independence file in the filtration file and move the lemmas there?

RemyDegenne
RemyDegenne reviewed Oct 31, 2022
View reviewed changes
src/measure_theory/measurable_space.lean Outdated Show resolved Hide resolved
src/measure_theory/measurable_space.lean Outdated Show resolved Hide resolved
src/probability/independence.lean Outdated Show resolved Hide resolved
src/probability/process/filtration.lean Outdated Show resolved Hide resolved
src/probability/process/filtration.lean Outdated Show resolved Hide resolved
src/probability/process/filtration.lean Outdated Show resolved Hide resolved
src/probability/process/filtration.lean Outdated Show resolved Hide resolved
JasonKYi and others added 2 commits October 31, 2022 10:59
@JasonKYi @RemyDegenne
Apply suggestions from code review
2c53f30 
Co-authored-by: Rémy Degenne <remydegenne@gmail.com>
@JasonKYi
move lemma
f3d0157
RemyDegenne
RemyDegenne approved these changes Oct 31, 2022
View reviewed changes
Copy link
Collaborator

@RemyDegenne RemyDegenne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove the todo in the file docstring of martingale/borel_cantelli? Otherwise LGTM. Thanks!
bors d+

@bors
Copy link

bors bot commented Oct 31, 2022

✌️ JasonKYi can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-bot-assistant leanprover-community-bot-assistant added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Oct 31, 2022
@JasonKYi
Copy link
Member Author

Thanks for the reviews!

bors r+

bors bot pushed a commit that referenced this pull request Oct 31, 2022
@JasonKYi @RemyDegenne
feat(probability/borel_cantelli): the second Borel-Cantelli lemma (#1…
1e7dab9 
…6882)

Co-authored-by: JasonKYi <kexing.ying19@imperial.ac.uk>
Co-authored-by: RemyDegenne <Remydegenne@gmail.com>
Co-authored-by: Kexing Ying <kexing.ying19@imperial.ac.uk>
@bors
Copy link

bors bot commented Oct 31, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(probability/borel_cantelli): the second Borel-Cantelli lemma [Merged by Bors] - feat(probability/borel_cantelli): the second Borel-Cantelli lemma Oct 31, 2022
@bors bors bot closed this Oct 31, 2022
@bors bors bot deleted the JasonKYi/bc_new branch October 31, 2022 17:43
@eric-wieser eric-wieser added the hacktoberfest-accepted Without this label hacktoberfest is scared off by bors label Nov 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b-mehta b-mehta b-mehta left review comments

@RemyDegenne RemyDegenne RemyDegenne approved these changes

Assignees
No one assigned
Labels
delegated The PR author may merge after reviewing final suggestions. hacktoberfest-accepted Without this label hacktoberfest is scared off by bors t-measure-probability Measure theory / Probability theory
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@JasonKYi @mathlib-dependent-issues-bot @RemyDegenne @b-mehta @eric-wieser @leanprover-community-bot-assistant