Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - refactor(set_theory/cardinal): review API about #α = 2/nat.card α = 2 #16899

Closed
wants to merge 3 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Oct 11, 2022

  • Rename cardinal.mk_eq_nat_iff_finset to cardinal.mk_set_eq_nat_iff_finset, add a version for types and cardinal.mk_eq_nat_iff_fintype.
  • Add cardinal.to_nat_eq_iff, a more general version of cardinal.to_nat_eq_one.
  • Rename cardinal.exists_not_mem_of_length_le to cardinal.exists_not_mem_of_length_lt.
  • Add cardinal.mk_eq_two_iff, cardinal.mk_eq_two_iff', nat.card_eq_two_iff, and nat.card_eq_two_iff'.

Open in Gitpod

@urkud urkud marked this pull request as ready for review October 11, 2022 00:06
@urkud urkud added awaiting-review The author would like community review of the PR blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. t-combinatorics Combinatorics labels Oct 11, 2022
@jcommelin
Copy link
Member

This looks good to me. Please merge it once the dep PR is merged.

bors d+

@bors
Copy link

bors bot commented Oct 11, 2022

✌️ urkud can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Oct 11, 2022
@mathlib-dependent-issues-bot mathlib-dependent-issues-bot removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Oct 12, 2022
@mathlib-dependent-issues-bot
Copy link
Collaborator

@urkud
Copy link
Member Author

urkud commented Oct 12, 2022

bors merge

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Oct 12, 2022
bors bot pushed a commit that referenced this pull request Oct 12, 2022
…= 2` (#16899)

* Rename `cardinal.mk_eq_nat_iff_finset` to `cardinal.mk_set_eq_nat_iff_finset`, add a version for types and `cardinal.mk_eq_nat_iff_fintype`.
* Add `cardinal.to_nat_eq_iff`, a more general version of `cardinal.to_nat_eq_one`.
* Rename `cardinal.exists_not_mem_of_length_le` to `cardinal.exists_not_mem_of_length_lt`.
* Add `cardinal.mk_eq_two_iff`, `cardinal.mk_eq_two_iff'`, `nat.card_eq_two_iff`, and `nat.card_eq_two_iff'`.
@bors
Copy link

bors bot commented Oct 12, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title refactor(set_theory/cardinal): review API about #α = 2/nat.card α = 2 [Merged by Bors] - refactor(set_theory/cardinal): review API about #α = 2/nat.card α = 2 Oct 12, 2022
@bors bors bot closed this Oct 12, 2022
@bors bors bot deleted the YK-card-two branch October 12, 2022 16:16
@eric-wieser eric-wieser added the hacktoberfest-accepted Without this label hacktoberfest is scared off by bors label Oct 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated The PR author may merge after reviewing final suggestions. hacktoberfest-accepted Without this label hacktoberfest is scared off by bors ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) t-combinatorics Combinatorics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants