Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(analysis/asymptotics): prove that a function has derivative 0 using asymptotics #16934

Closed
wants to merge 5 commits into from
Closed

[Merged by Bors] - feat(analysis/asymptotics): prove that a function has derivative 0 using asymptotics #16934

wants to merge 5 commits into from

Conversation

fpvandoorn
Copy link
Member

@fpvandoorn fpvandoorn commented Oct 12, 2022 •
edited by PatrickMassot

  • From the sphere eversion project
  • Needed for computing derivatives of the parametric interval integral

Co-authored by: Patrick Massot patrickmassot@free.fr

Open in Gitpod

@fpvandoorn fpvandoorn added awaiting-review The author would like community review of the PR awaiting-CI The author would like to see what CI has to say before doing more work. labels Oct 13, 2022
@ADedecker ADedecker self-assigned this Oct 13, 2022
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Oct 13, 2022
@fpvandoorn fpvandoorn changed the title feat(analysis/asymptotics): misc lemmas feat(analysis/asymptotics): prove that a function has derivative 0 using asymptotics Oct 14, 2022
@ADedecker ADedecker added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Oct 14, 2022
@fpvandoorn fpvandoorn added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Oct 16, 2022
fpvandoorn added a commit that referenced this pull request Oct 16, 2022
@fpvandoorn
add lemma (same change as in #16934)
ce11650
@sgouezel
Copy link
Collaborator

The linter is not happy. Otherwise, LGTM but I'll wait for @ADedecker review.

@fpvandoorn
Copy link
Member Author

fpvandoorn commented Oct 17, 2022 •
edited

That commit is misleading, it is not part of this PR, but references this PR.

ADedecker
ADedecker approved these changes Oct 18, 2022
View reviewed changes
Copy link
Member

@ADedecker ADedecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay, now there are conflicts :/

Otherwise this looks good to me

@fpvandoorn
Copy link
Member Author

Tiny conflict with one of my own PRs, so no big deal.

@ADedecker
Copy link
Member

Thanks!

maintainer merge

@github-actions
Copy link

🚀 Pull request has been placed on the maintainer queue by ADedecker.

@PatrickMassot PatrickMassot added awaiting-CI The author would like to see what CI has to say before doing more work. and removed awaiting-review The author would like community review of the PR labels Oct 18, 2022
@sgouezel
Copy link
Collaborator

bors d+

@bors
Copy link

bors bot commented Oct 18, 2022

✌️ fpvandoorn can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-CI The author would like to see what CI has to say before doing more work. labels Oct 18, 2022
@fpvandoorn
Copy link
Member Author

bors merge

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Oct 19, 2022
bors bot pushed a commit that referenced this pull request Oct 19, 2022
@fpvandoorn
feat(analysis/asymptotics): prove that a function has derivative 0 us…
8bf2477 
…ing asymptotics (#16934)

* From the sphere eversion project
* Needed for computing derivatives of the parametric interval integral

Co-authored by: Patrick Massot [patrickmassot@free.fr](patrickmassot@free.fr)
@bors
Copy link

bors bot commented Oct 19, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(analysis/asymptotics): prove that a function has derivative 0 using asymptotics [Merged by Bors] - feat(analysis/asymptotics): prove that a function has derivative 0 using asymptotics Oct 19, 2022
@bors bors bot closed this Oct 19, 2022
@bors bors bot deleted the asymptotics_for_integral branch October 19, 2022 11:59
@eric-wieser eric-wieser added the hacktoberfest-accepted Without this label hacktoberfest is scared off by bors label Oct 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ADedecker ADedecker ADedecker approved these changes

Assignees

@ADedecker ADedecker

Labels
delegated The PR author may merge after reviewing final suggestions. hacktoberfest-accepted Without this label hacktoberfest is scared off by bors ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@fpvandoorn @sgouezel @ADedecker @eric-wieser @PatrickMassot