Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore(analysis/normed/group/basic): Earlier ℝ lemmas #16972

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - chore(analysis/normed/group/basic): Earlier ℝ lemmas #16972

wants to merge 3 commits into from

Conversation

YaelDillies
Copy link
Collaborator

@YaelDillies YaelDillies commented Oct 14, 2022 •
edited
Loading

Move lemmas about the norm on ℝ from analysis.normed.field.basic to analysis.normed.group.basic.

This avoids having to import normed_field to use real.norm_of_nonneg.

Open in Gitpod

@YaelDillies YaelDillies added awaiting-review The author would like community review of the PR t-analysis Analysis (normed *, calculus) labels Oct 14, 2022
@YaelDillies YaelDillies mentioned this pull request Oct 14, 2022
Closed
2 tasks
@eric-wieser
Copy link
Member

This is probably sensible, but can you add a justification to the PR description?

@YaelDillies
Copy link
Collaborator Author

Done!

@ocfnash ocfnash added the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Oct 24, 2022
@ocfnash
Copy link
Collaborator

ocfnash commented Oct 24, 2022

I agree this is probably a good idea. I note there is now a merge conflict however.

@YaelDillies YaelDillies removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Oct 28, 2022
@mcdoll
Copy link
Member

mcdoll commented Oct 29, 2022

maintainer merge

@github-actions
Copy link

🚀 Pull request has been placed on the maintainer queue by mcdoll.

@mcdoll mcdoll changed the title move(analysis/normed/group/basic): Earlier ℝ lemmas chore(analysis/normed/group/basic): Earlier ℝ lemmas Oct 29, 2022
@sgouezel
Copy link
Collaborator

bors r+

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Oct 29, 2022
bors bot pushed a commit that referenced this pull request Oct 29, 2022
@YaelDillies
chore(analysis/normed/group/basic): Earlier ℝ lemmas (#16972)
be61b02 
Move lemmas about the norm on `ℝ` from `analysis.normed.field.basic` to `analysis.normed.group.basic`.

This avoids having to import `normed_field` to use `real.norm_of_nonneg`.
@bors
Copy link

bors bot commented Oct 29, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(analysis/normed/group/basic): Earlier ℝ lemmas [Merged by Bors] - chore(analysis/normed/group/basic): Earlier ℝ lemmas Oct 29, 2022
@bors bors bot closed this Oct 29, 2022
@bors bors bot deleted the nnnorm_mul_to_nnreal branch October 29, 2022 11:27
@eric-wieser eric-wieser added the hacktoberfest-accepted Without this label hacktoberfest is scared off by bors label Oct 29, 2022
@YaelDillies YaelDillies mentioned this pull request Oct 30, 2022
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
hacktoberfest-accepted Without this label hacktoberfest is scared off by bors ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) t-analysis Analysis (normed *, calculus)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@YaelDillies @eric-wieser @ocfnash @mcdoll @sgouezel